Fix issues reported by phpcs

issues fixed

Hi @vishal365365,

Applied your patch, it fixed some issues, however, found new issues, kindly see below.

FILE: .../drupal-orgissue/web/modules/contrib/gmail/src/Plugin/Mail/GmailSystem.php
--------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------
 127 | ERROR | [x] The first parameter of a multi-line function declaration
     |       |     must be on the line after the opening bracket
 128 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 129 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 130 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 131 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 132 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 133 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 134 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 135 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 136 | ERROR | [x] Multi-line function declaration not indented correctly;
     |       |     expected 4 spaces but found 30
 136 | ERROR | [x] Multi-line function declarations must have a trailing comma
     |       |     after the last parameter
 136 | ERROR | [x] The closing parenthesis of a multi-line function declaration
     |       |     must be on a new line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 895ms; Memory: 16MB

Thank you.

Hi @atul_ghate,

Successfully applied MR !3, all issues are fixed.

 gmail git:(1.0.x) ✗ curl https://git.drupalcode.org/project/gmail/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6211    0  6211    0     0  15540      0 --:--:-- --:--:-- --:--:-- 15925
patching file src/Controller/CalbackController.php
patching file src/Form/GmailConfigForm.php
patching file src/Plugin/Mail/GmailSystem.php
➜  gmail git:(1.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gmail
➜  contrib git:(main) ✗

Will move this to RTBC.

Thanks,
Jake

Jeya sundhar → made their first commit to this issue’s fork.

Automatically closed - issue fixed for 2 weeks with no activity.