- Issue created by @Prachi6824
- Assigned to Prachi6824
- Status changed to Needs review
over 1 year ago 3:06pm 26 June 2023 - ๐ฎ๐ณIndia Prachi6824
Hello,
I have created a patch to solve some of the errors related to phpcs .
Please review and apply it .
It will not be solving the following error:FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
4415 | ERROR | Style definitions must end with a semicolon
7662 | ERROR | Style definitions must end with a semicolon
7672 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------- - ๐ฎ๐ณIndia Harshita mehra
Harshita mehna โ made their first commit to this issueโs fork.
- Status changed to RTBC
over 1 year ago 4:53pm 28 June 2023 - ๐ต๐ญPhilippines clarkssquared
Hi prachi6824
I applied your patch #2 to my local and I confirmed that your patch fixes the PHPCS issues in estore.theme file
Providing screenshot after applying the patch, kindly check.
Thank you
- ๐ฎ๐ณIndia Prachi6824
Thank you @clarkssquared for reviewing my patch .
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 11:50pm 2 October 2023 - Assigned to Gautam_105@
- @gautam_105 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:38am 3 October 2023 - ๐ฎ๐ณIndia Gautam_105@
Hello @danrod,
i have apply patch but getting error , After that fix and create MR fo the same Please review and see attachement - Status changed to RTBC
over 1 year ago 7:25pm 3 October 2023 - Status changed to Fixed
over 1 year ago 7:29pm 3 October 2023 - ๐จ๐ฆCanada danrod Ottawa
Thanks everyone for the work on this ! Changed it to "Fixed".
Automatically closed - issue fixed for 2 weeks with no activity.