Clarify why FieldConfigBase::getDataType() is 'list' and not 'field_config_base'

First, let's find out what is using this… 🤓

Seemed to cause some failures.

kindly review the patch.

Still caused some failure.

And was tagged for issue summary update

I discussed this at drupal dev days 2023. We think that this is actually not an issue. The call to getDataType here is actually about the content of what is in the field, not about the field itself. Since all (or at least most) fields are lists, returning list here is correct.

FieldConfigBase implements the DataDefinitionInterface, that one provides this method.

I think we should close this one as won't fix.

Added some inline docs, so the next one who tries this does not run in to the same issue as I did. Did this based on feedback by @lauriii at drupal dev days.

Documentation change looks good.

Updated IS with #7

I agree with the conclusion, the data type as is is correct, since the field-config is actually a typed-data-definition for field-item-lists, not for the config. I'd suggest to improve the comment a bit more though, "contents of field-config" seems confusing. I'm rolling a new one.

fago → closed merge request !4445

added it as new MR: https://git.drupalcode.org/project/drupal/-/merge_requests/4446

Hopefully that explains it will. FieldConfigBase config type is used for the schema, describing field-config entities. Field config entities are the "schema" / data definitions describe field-item lists, and those are "list".

Updated issue title to reflect what the change is doing

That is a lot better than what I had written. Thanks @fago!

Back to RTBC.

Committed 4571fda and pushed to 11.x. Thanks!

Backported to 10.1.x as a docs change.

lauriii → closed merge request !4446

Automatically closed - issue fixed for 2 weeks with no activity.