[regression] Space inserted before full stop, comma, etc

I think the trimming algorithm will need to distinguish between paragraph type tags (<p> <div> <h1>) and inline type tags (<em> <str>), and only add a space for the paragraph ones. This will make the code a bit more complex.

@lostcarpark, I don’t think we have to reinvent the wheel. There must be some good libraries out there that are already doing this

as of #7

I am writing a test for this...

-mike

Test added. Ready for review.

-mike

@Anybody, why the new !67 merge request?

The existing one, !57 has the updated test is it...

-mike

Anybody → closed merge request !67

Sorry! I clicked there accidentally, the fork was already existing. Closed it!

Yet another PHPCS fix needed. Long URL can probably be on it's own comment line.

@Anybody - got it. No worries.

@markie - phpcs issue fixed.

-mike

Applied MR !57 changes on local, it fix the issue successfully and working fine. Now there is no space is there before before full stop, comma. Attached Before and After image for reference. Hence +1 RTBC..

Thank you for testing and fixing the PHPCS.. Merged in #57.

Thank you so much for the fix. However, maybe on the next major version we can think on using a 3rd-party that is specialized in striping the tags in a smart way. I've suggested https://github.com/mtibben/html2text but there might be also other tools out in the wild.

Automatically closed - issue fixed for 2 weeks with no activity.