Automated Drupal 10 compatibility fixes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.

Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. mglaman/phpstan-drupal: 1.1.35
2. palantirnet/drupal-rector: 0.15.1

Assigning to myself to check against what's already been merged.

This is the change record: https://www.drupal.org/node/2907725 →

I looked and some of the code wasn't changed that should have been so marking as needs work.

Kristens-MacBook-Pro:fast_404 kristenpol$ grep -r getMockBuilder .
./tests/src/Unit/Fast404Test.php:    $fast404 = $this->getMockBuilder('\Drupal\fast404\Fast404')
./tests/src/Unit/Fast404EventSubscriberTest.php:    $fast404FactoryStackStub = $this->getMockBuilder('\Drupal\fast404\Fast404Factory')
./tests/src/Unit/Fast404EventSubscriberTest.php:    $subscriber = $this->getMockBuilder('\Drupal\fast404\EventSubscriber\Fast404EventSubscriber')

I thought it was a rector issue so opened an issue:

🐛 Rector rule for updating getMockBuilder is not catching all instances Closed: works as designed

but then I see those other places are chaining a method (setConstructorArgs) that can't be thrown out, so I closed that issue.

This one should be ready to merge but I'll doublecheck by running some extra automated. tests on the patch.

Automated tests passed so this is ready to merge.

https://www.drupal.org/project/fast_404/releases/8.x-3.2 →

Automatically closed - issue fixed for 2 weeks with no activity.