^8.8 || ^9 || ^10
Whatever the Project Update Bot is using.
This Drupal 10 compatibility issue:
📌 Automated Drupal 10 compatibility fixes Fixed
makes this change:
- $fast404FactoryStackStub = $this->getMockBuilder('\Drupal\fast404\Fast404Factory')
- ->disableOriginalConstructor()
- ->getMock();
+ $fast404FactoryStackStub = $this->createMock('\Drupal\fast404\Fast404Factory');
$subscriber = $this->getMockBuilder('\Drupal\fast404\EventSubscriber\Fast404EventSubscriber')
->setConstructorArgs([$requestStackStub, $fast404FactoryStackStub])
->getMock();
but, when I grep for getMockBuilder, I see more places this is used:
Kristens-MacBook-Pro:fast_404 kristenpol$ grep -r getMockBuilder .
./tests/src/Unit/Fast404Test.php: $fast404 = $this->getMockBuilder('\Drupal\fast404\Fast404')
./tests/src/Unit/Fast404EventSubscriberTest.php: $fast404FactoryStackStub = $this->getMockBuilder('\Drupal\fast404\Fast404Factory')
./tests/src/Unit/Fast404EventSubscriberTest.php: $subscriber = $this->getMockBuilder('\Drupal\fast404\EventSubscriber\Fast404EventSubscriber')
Note this issue, though, where there is a fundamental question about whether the bot should be doing this in the first place:
🐛 Unclear replacement of getMockBuilder() with createMock(). Active
Closed: works as designed
Code
Actually, this is probably working as designed... I see the other two instances are using setConstructorArgs which isn't listed in the USELESS_METHOD_NAMES here:
https://github.com/rectorphp/rector-phpunit/blob/c4caecafa38f3d6f09147f2...
so closing this.