Contrib.social

Found some phpcode standard related issues in style.css

Open on Drupal.org ā†’
Created on 23 June 2023, over 1 year ago
Updated 13 August 2024, 4 months ago

Problem/Motivation

As, I run the command for pHpcs issues I Found some phpcode standard related issues in style.css .

Steps to reproduce

Need to fix these issues

----------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
2 | ERROR | [x] Closing brace of class definition must be on new line
5 | ERROR | [x] Closing brace of class definition must be on new line
9 | ERROR | [x] Closing brace of class definition must be on new line

šŸ“Œ Task
Status

RTBC

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India Prachi6824

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @Prachi6824
  • Assigned to Prachi6824
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India Prachi6824

    Hello,

    I have created a patch to solve all the errors related to phpcs code standard within the style.css file .
    Please review and apply it .

  • Issue was unassigned.
  • Comment 11 months ago ā†’
    šŸ‡·šŸ‡ŗRussia zniki.ru
  • Comment 5 months ago ā†’
    a.aaronjake

    Hi @prachi6824,

    The patch you provided was applied successfully, confirmed errors reported are fixed. Please see below:

    cleanimal git:(1.x) curl https://www.drupal.org/files/issues/2023-06-23/3369079-%232.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   444  100   444    0     0   3174      0 --:--:-- --:--:-- --:--:--  3468
patching file css/base/style.css
āžœ  cleanimal git:(1.x) āœ— cd ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig cleanimal/css/b
ase
āžœ  contrib git:(master) āœ—

    RTBC +1 from me.

    Thanks,
    Jake

  • Status changed to RTBC 4 months ago
  • Comment 4 months ago ā†’
    a.aaronjake
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024