Using php 8.1 the settings form at /admin/config/system/hidden_language is inaccessible if the form values are empty.
Drupal: 9.5.9
PHP: 8.1.19
The website encountered an unexpected error. Please try again later.
TypeError: implode(): Argument #1 ($pieces) must be of type array, string given in implode() (line 66 of modules/contrib/hidden_language/src/Form/HiddenLanguageForm.php).After installing go to /admin/config/system/hidden_language .
In HiddenLanguageManager in functions getRoutesException() and getRoutesException() check if the returned setting is null and return an empty array instead of calling json_decode().
--- a/web/modules/contrib/hidden_language/src/HiddenLanguageManager.php
+++ b/web/modules/contrib/hidden_language/src/HiddenLanguageManager.php
@@ -56,7 +56,7 @@ public function __construct(ConfigFactory $config_factory, PathValidator $path_v
* Array of configurated routes.
*/
public function getRoutesException() {
- return json_decode($this->hiddenLanguageSettings->get('route_name'));
+ return $this->hiddenLanguageSettings->get('route_name') ? json_decode($this->hiddenLanguageSettings->get('route_name')) : [];
}
/**
@@ -66,7 +66,7 @@ public function getRoutesException() {
* Array of configurated paths.
*/
public function getPathsException() {
- return json_decode($this->hiddenLanguageSettings->get('path'));
+ return $this->hiddenLanguageSettings->get('path') ? json_decode($this->hiddenLanguageSettings->get('path')) : [];
}
Needs review
2.0
Code
The issue particularly affects sites running on PHP version 8.1.0 or later.
Hi I just added the suggestion in the issue summary, it fixed the issue please revise.
Patch is not applying with 2.x version. Here is compatible patch.