Trim the right-hand slash on namespace paths

Twig\Error\LoaderError: Template "@templates/node/node--layout--movies-hub.twig" is not defined in "sites/****/themes/custom/****/templates/node/full/node--layout--movies-hub.html.twig" at line 1. in Twig\Loader\ChainLoader->getCacheKey() (line 98 of /var/www/html/vendor/twig/twig/src/Loader/ChainLoader.php). Twig\Environment->getTemplateClass('@templates/node/node--layout--movies-hub.twig', NULL) (Line: 204) Drupal\Core\Template\TwigEnvironment->getTemplateClass('@templates/node/node--layout--movies-hub.twig') (Line: 381) Twig\Environment->loadTemplate('@templates/node/node--layout--movies-hub.twig', NULL) (Line: 333) Twig\Template->loadTemplate('@templates/node/node--layout--movies-hub.twig', 'sites/****/themes/custom/****/templates/node/full/node--layout--movies-hub.html.twig', 1) (Line: 39) __TwigTemplate_88d77c497f448d9b8b0a12ac99839522105af94ff250d171bac18ca30c7ff718->doDisplay(Array, Array) (Line: 405) Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378) Twig\Template->display(Array) (Line: 390) Twig\Template->render(Array) (Line: 55) twig_render_template('sites/****/themes/custom/****/templates/node/full/node--layout--movies-hub.html.twig', Array) (Line: 384) Drupal\Core\Theme\ThemeManager->render('node', Array) (Line: 433) Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 204) Drupal\Core\Render\Renderer->render(Array, ) (Line: 242) Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 580) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 243) Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132) Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90) Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object) call_user_func(Array, Object, 'kernel.view', Object) (Line: 142) Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 174) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106) Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23) Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comments & Activities

Issue created by @marcoscano
Comment over 1 year ago →
🇪🇸Spain marcoscano Barcelona, Spain
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
last update over 1 year ago
61 pass
Comment over 1 year ago →
🇪🇸Spain marcoscano Barcelona, Spain
Turns out I was wrong suspecting from the long paths, that was my IDE playing a trick with me. Turns out the keys were fine and not trimmed at all.

On the other hand, I did find that sometimes (I'm guessing when the namespace pointed to a custom site-specific (in a multi-site) theme directory) we had a trailing slash, which made the str_replace() not do the job it was supposed to do.

Attached patch that seems to solve the issue for us.
Status changed to Needs review over 1 year ago8:57am 4 July 2023
Comment over 1 year ago →
🇪🇸Spain marcoscano Barcelona, Spain
Status changed to RTBC over 1 year ago8:39am 7 July 2023
Comment over 1 year ago →
e0ipso Can Picafort
This is working good in our install. Thanks for the patch @marcoscano!

Comment over 1 year ago →

🇧🇷Brazil julio_retkwa Balneário Camboriú

#3 working fine for me as I had to follow the new standard described here: https://www.drupal.org/docs/contributed-modules/components/registering-t... →

TL:DR
I had to replace my theme.info.yml section from this:

component-libraries:
  base:
    paths:
      - components/00-base
  atoms:
    paths:
      - components/01-atoms
  molecules:
    paths:
      - components/02-molecules
  organisms:
    paths:
      - components/03-organisms

To something like:

components:
  namespaces:
    base: components/00-base
    atoms: components/01-atoms
    molecules: components/02-molecules
    organisms: components/03-organisms
    templates: components/04-templates
    pages: components/05-pages

Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update about 1 year ago
61 pass
Comment about 1 year ago →
🇺🇸United States joycehutch Kansas City, MO
Thanks @julio_retkwa! I also had to change the theme.info.yml with the same, because of pattern lab configuration. This was helpful!
Comment about 1 year ago →
🇨🇦Canada joelpittet Vancouver
I wonder if a BC layer can be added to help ease people off of 2.x?

Thanks @julio_retkwa for the TL;DR
Comment about 1 year ago →
🇦🇺Australia pasan.gamage
Thanks @julio_retkwa
Saved me a heap of time!
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22
last update about 1 year ago
61 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MariaDB 10.3.22
last update about 1 year ago
61 pass

Comment 11 months ago →

System Message

RobLoach → committed 0b46c285 on 3.x

Issue #3368589 by marcoscano, RobLoach: Trim the right-hand slash on...

Status changed to Fixed 11 months ago7:04pm 25 January 2024
Comment 11 months ago →
🇨🇦Canada RobLoach Earth
Small fix to switch the string to use single-quotes instead of double quotes. We're not processing any variables in the string so ' is what we want. Thanks all!
Comment 11 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Trim the right-hand slash on namespace paths

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities