- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:39am 22 June 2023 - last update
over 1 year ago 30 pass - Status changed to Needs work
over 1 year ago 9:21am 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- $source_vid = ($source_entity instanceof RevisionableInterface && $source_entity->getRevisionId()) ? $source_entity->getRevisionId() : 0; + ($source_entity instanceof RevisionableInterface && $source_entity->getRevisionId()) ? $source_entity->getRevisionId() : 0;The changed line is not even equivalent to the existing line: The existing line is assigning a value to a variable, which is not what the changed line does.
- $storage = $this->entityTypeManager->getStorage('entity_test_mulrevpub'); + $this->entityTypeManager->getStorage('entity_test_mulrevpub');The same holds true here.
- Status changed to RTBC
over 1 year ago 9:26am 22 June 2023 - Assigned to nitin_lama
- last update
over 1 year ago 30 pass - 🇮🇳India nitin_lama India
Addressed #3. Please review. Also the user who provided the patch cannot change status to Reviewed & tested by the community.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:32am 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The last patch correctly changes the code as per issue scope.
- 🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.
- Status changed to RTBC
6 months ago 5:45am 21 May 2024 - 🇮🇳India aman1248
Hy @marcoscano ,
I have reviewed the changes in the the MR!6 , The MR! has a straight forward fix.
It can be merged.
Please & Thank You.** Marking this ticket as RTBC!!