- Issue created by @Shamrockonov
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @Shamrockonov could you please provide the fix as MR?
- Status changed to Needs work
over 1 year ago 12:00pm 21 June 2023 - last update
over 1 year ago 27 pass - @shamrockonov opened merge request.
- 🇬🇧United Kingdom Shamrockonov
Just created it. Hopefully i've done that right!
- Status changed to RTBC
over 1 year ago 12:56pm 21 June 2023 - last update
over 1 year ago 27 pass - 🇩🇪Germany Anybody Porta Westfalica
Thanks yeah, LGTM!
RTBC from my side, leaving this for @Grevil to review finally, check for potential other cases like this and create a new tagged release, please.
-
Shamrockonov →
committed c4ae965a on 2.0.x
Issue #3368248 Missing return keyword when returning AccessResult::...
-
Shamrockonov →
committed c4ae965a on 2.0.x
- Status changed to Fixed
over 1 year ago 1:10pm 21 June 2023 - 🇩🇪Germany Grevil
Wonder why the tests didn't pick that up...
Released 2.0.4 with your quick fix!
https://www.drupal.org/project/entity_access_by_role_field/releases/2.0.4 → - 🇩🇪Germany Grevil
Created a follow up issue for creating appropriate tests here ✨ Create Fallback Neutral tests with no roles set Needs work
Automatically closed - issue fixed for 2 weeks with no activity.