- Issue created by @paraderojether
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 1:44am 20 June 2023 - ๐ต๐ญPhilippines paraderojether
I created a patch to fix the issues reported by phpcs except for the dependency injection.
I hope there is someone who can help to fix the dependency injection issues.
Thank You. - Assigned to nitin_lama
- ๐ฎ๐ณIndia nitin_lama
Only one DI warning remaining. Not sure if this is a core service or not.
FILE: /home/system/Documents/contribution/changelog/src/Controller/PageController.php --------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------- 80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------- Time: 35ms; Memory: 6MB
- Issue was unassigned.
- ๐ฎ๐ณIndia kbk1992 Hyderabad
bharath-kondeti โ made their first commit to this issueโs fork.
- last update
about 1 year ago 1 pass - @bharath-kondeti opened merge request.
- ๐ฎ๐ณIndia kbk1992 Hyderabad
Tried to fix DI issue. But it depends on git_info module. It will throw an issue if we fix it. We have to require git_info module in composer and fix this. Also, moved patch to MR. https://git.drupalcode.org/project/changelog/-/merge_requests/4