Contrib.social

Properly handle <!--break--> HTML comment

Open on Drupal.org →
Created on 18 June 2023, about 1 year ago
Updated 19 June 2023, about 1 year ago

This issue has been spun off from 🐛 Truncate must not count HTML comments Fixed .

How should we handle HTML <!--break-->?

  1. Should we treat this as an HTML comment and not count it?
  2. If Smart Trim sees this, should it automatically return the text before it as the trimmed text (and ignore the formatter configuration)?

With option 2, we would be treating <!--break--> as a "golden ticket" and allow it to dictate what is returned by the formatter.

With option 1, we would be ignoring any possible intent by authors to "hard code" the summary into the body field by manually inserting a <!--break-->.

I am leaning towards option 1 as <!--break--> is kind of out-dated (IMHO).

Thoughts?

-mike

📌 Task
Status

Active

Version

2.1

Component

Code

Created by

🇺🇸United States ultimike Florida, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @ultimike
  • Comment about 1 year ago →
    🇺🇸United States markie Albuquerque, NM

    I am leaning towards #1 as well. Should be documented though.

  • Comment about 1 year ago →
    🇮🇪Ireland lostcarpark

    Just looking at the CKEditor options, and there doesn't seem to be an option to insert a <!--break-->, at least in the default button set. I think the preferred option nowadays is to use the summary field. So option 1 sounds the preferred choice to me.

    Agree it should be documented.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024