Properly handle <!--break--> HTML comment

I am leaning towards #1 as well. Should be documented though.

Just looking at the CKEditor options, and there doesn't seem to be an option to insert a <!--break-->, at least in the default button set. I think the preferred option nowadays is to use the summary field. So option 1 sounds the preferred choice to me.

Agree it should be documented.

Option 2 is my preferred choice, especially while core is supporting <!--break-->.

I doubt it would take much work to create a CKEditor option to insert <!--break--> (but that is beyond the scope of this issue/module).

MR on its way...

• Set correct version
• Created merge requests
• Added Needs Tests tag
• Set status to Needs Work

For the record there is a contrib module that allows <!--break--> in ckeditor https://www.drupal.org/project/ckeditor_drupalbreaks →

I tried this out and it didnt quite work for me.

the <!--break--> tag is still ignored when creating the trimmed version.

It would make sense to use <!--break--> to end the text if it comes within the smart trim limit.

For example, if Smart Trim was set with a limit of 100 characters, and a <!--break--> was present at character 50, then Smart Trim would return up to the <!--break-->.

However, if the <!--break--> came at character 150, then Smart Trim's normal rules would apply, and only the first 100 characters (adjusted for word breaks) would be returned.

As an extra module is required to support the <!--break--> with CKEditor, I don't think this is widely used, I wonder should there be a config option added to enable support of <!--break-->? If selected, text would be trimmed at <!--break-->, if it appeared within the trim length. If not enabled, <!--break--> would be treated as a comment.