Truncate must not count HTML comments

I'm happy to give this a proper review, but I'd like to add some test coverage for this change. I'm happy to add the test coverage, but I'd like some assistance in making sure we are testing the right stuff. I'm fine with both traditional code comments and the

tag being part of this single issue as long as there is proper code coverage for both.

Our Unit tests allow us to test both trimming by characters and words. The input data for the character trimming test looks like this:

- The string to be trimmed.
- Number of characters to be trimmed.
- Suffix.
- Expected output.

So, as an example,

- This is the string to be trimmed. 
- 15
- ...
- This is the string...

Similarly, for the word trimming test, the input data is:

- The string to be trimmed.
- Number of words to be trimmed.
- Suffix.
- Expected output.

It would be great for someone to provide some input data for the tests in a comment below (or add it to the patch!) that includes both twig_debug style code comments and a

tag.

Make sense?

thanks,
-mike

Forgot to change the status...

New patch for 2.1.x added.

I agree with @eelkeblok that we should spin the

stuff off into a separate issue. I have done so: 📌 Properly handle HTML comment Active .

Moving forward, this issue will utilize the issue fork (no more patches, please) and focus on non-break HTML comments only.

I have updated the issue title to reflect this change.

Fix and tests ready for review in issue fork. All tests are passing.

I took a slightly different approach than the patches from @ckaotik and @Ruedische - the code I added to the service methods removes all comment elements from the DOM before our trimming code gets going.

-mike

Thinking about this while I was offline (I know, right?) I realized that the DOM comment remover wasn't going to remove all comment elements. I've improved it and added more realistic tests.

Ready for review.

-mike

Assigning this back to me. Also, I'll look into adding a unit test specifically for the new removeHtmlComments() method.

-mike

@markie,

I've moved removeHtmlComments() as suggested and added a new unit test specifically for it.

-mike

See comments in MR.

reviewed and merged. Thanks for the assistance.

Automatically closed - issue fixed for 2 weeks with no activity.