Generate machine names even faster

The last submitted patch, 2: 3367420-2.patch, failed testing. View results →

Because there is no more ajax involved I'd probably listen directly to the change and input event for machine names instead of relying on the the formUpdated event.

Works for me!

No failures is always good.

Applied the patch and tested by creating a content type and the machine name field updated as I typed.

So is next step to make these faster to generate them before I open my laptop? haha

minor thing but could be useful to add a comment to say why we're not using formupdated and using change/input is fine since there is no ajax request involved

Good idea 👍 Moving back to RTBC since the interdiff is just for a simple inline code comment. Feel free to adjust the comment if you think it should be worded differently. 😊

almost there. We need to keep the event namespace since it's used to remove event listeners when clicking on the edit button. Right now when clicking edit and changing the field name, the machine name is also updated.

Good catch 👍 I searched for the whole event with the namespace but not for just the namespace 🙈

yarn prettier 😇

Committed 947e079 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.