- Issue created by @idebr
- Status changed to Needs review
over 1 year ago 2:34pm 16 June 2023 - π³π±Netherlands idebr
Attached patch determines media:content width and height attributes from the image style instead of the original image.
- Status changed to RTBC
over 1 year ago 8:05am 19 June 2023 - π³π±Netherlands Lendude Amsterdam
This just uses the same logic that already exists in views_rss_media_getid3_preprocess_media_thumbnail, so that looks good.
Manually tested this and it works.
- Status changed to Needs review
over 1 year ago 7:02am 28 June 2023 - π§πͺBelgium nils.destoop
An updated patch. The media:content (and also media:thumbnail) was missing the width / height if the image didn't exist yet.
The patch now creates the derivative if it doesn't exist yet. - π§πͺBelgium nils.destoop
Updated patch as the file_exists also needed to be added
- π³π±Netherlands idebr
Moving to the views_rss issue queue.
Attached patch is a reroll of #2 against 8.x-2.x. The issue in #4 is fixed in π Restore itok parameter to image URLs in Media elements Fixed
- last update
over 1 year ago 2 pass - Status changed to RTBC
over 1 year ago 11:12am 11 July 2023 - πΊπΈUnited States DamienMcKenna NH, USA
That looks good, thanks for putting it together.
-
DamienMcKenna β
committed a7e6ea0c on 8.x-2.x authored by
idebr β
Issue #3367284 by idebr, nils.destoop, Lendude, DamienMcKenna: media:...
-
DamienMcKenna β
committed a7e6ea0c on 8.x-2.x authored by
idebr β
- Status changed to Fixed
over 1 year ago 12:32pm 11 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.