- Issue created by @sonam_sharma
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 11:04am 3 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what should be fixed/changed. Neither the title nor screenshots are sufficient to describe what the issue is, even in the case a patch is provided.
In the case of a bug, the description should also list the steps necessary to reproduce the issue, starting from when the module/theme is installed. - Status changed to Closed: works as designed
almost 2 years ago 6:42am 4 July 2023 - 🇮🇳India ashutosh ahirwal India
@sonam_sharma I have checked your patch the $i is use to add the increment value of number of slides on form and to differentiate the name of each field in slides.
And removing the $i is not a correct way to solve the phpcs issue.- '#title' => t('Slide ' . $i), + '#title' => t('Slide'),Kindly install and test the project in actual scenario before creating issues.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The patch is wrong, but the first argument passed to
t()needs to be a literal string.t('Slide ' . $i)needs to be replaced byt('Slide @number', ['@number' => $i]), for example.