[1.x] Asymmetric Encryption

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

None of those links are for manual reviews of other applications. We are not interested in the involvement in other issue queues.

Ran PHPCS tests. No issues were found. Let's wait for other reviewers

Can any one review this.

Fix PHPCS issue.

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,php  web/modules/contrib/asymmetric_encryption/

FILE: /web/modules/contrib/asymmetric_encryption/README.md
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------
 18 | WARNING | Line exceeds 80 characters; contains 139 characters
----------------------------------------------------------------------------------------


FILE: /web/modules/contrib/asymmetric_encryption/src/Services/Encryption.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /web/modules/contrib/asymmetric_encryption/asymmetric_encryption.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Hi @shashank5563
Thanks for the review and your valuable time. As it has the stable release.
project, datestamp, version has been added drupal.org.

Other than this, remaining issues are not listed for me.
Attached image for reference.

The Drupal.org packaging script does not do commits on drupal.org repositories. It adds lines like the following when the archive containing a project file for a project release is created.

# Information added by Drupal.org packaging script on 2023-06-19
version: '1.0.0'
project: 'asymmetric_encryption'
datestamp: 1687154243

These lines must be removed from the committed files.

libraries:
  - paragonie/halite

Drupal core does not use a libraries key. Composer dependencies must be put in a composer.json file.

Thanks @apaderno
As mentioned the composer.json has been added.

composer require 'drupal/asymmetric_encryption:^1.2'

I am changing priority as per Issue priorities.

No issues found
Changing status to RTBC!

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Thanks @all for all your valuable time.

Automatically closed - issue fixed for 2 weeks with no activity.