- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 9:44am 14 June 2023 - last update
about 1 year ago 56 pass - 🇮🇳India dev16.addweb
Re-roll the patch #2 🐛 Unused variables. Needs review according to the latest code changes.
- Status changed to Needs work
about 2 months ago 11:44am 10 July 2024 - 🇮🇳India VinmayiSwamy
Hi,
I applied patch entity_browser-3366693-3.patch → to the entity_browser → module against version 8.x-2.x-dev → in Drupal version 10.3.x.The patch was applied cleanly..
$ git apply -v entity_browser-3366693-3.patch Checking patch entity_browser.views.inc... Checking patch modules/entity_form/entity_browser_entity_form.module... Checking patch src/Form/EntityBrowserEditForm.php... Checking patch src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php... Checking patch tests/src/FunctionalJavascript/ConfigurationTest.php... Hunk #1 succeeded at 198 (offset -1 lines). Checking patch tests/src/FunctionalJavascript/EntityBrowserTest.php... Applied patch entity_browser.views.inc cleanly. Applied patch modules/entity_form/entity_browser_entity_form.module cleanly. Applied patch src/Form/EntityBrowserEditForm.php cleanly. Applied patch src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php cleanly. Applied patch tests/src/FunctionalJavascript/ConfigurationTest.php cleanly. Applied patch tests/src/FunctionalJavascript/EntityBrowserTest.php cleanly.Test Result:
Few phpcs issues were fixed, but several errors and warnings were still present../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/entity_browser FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/modules/entity_browser_test/entity_browser_test.routing.yml ---------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction ---------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/modules/entity_browser_test/src/Form/FormElementTest.php ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------- 33 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/EntityBrowserWebDriverTestBase.php ---------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\field\Entity\FieldConfig. 254 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters 288 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters 313 | ERROR | [x] Scope keyword "protected" must be followed by a single space; found 2 ---------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/EntityBrowserViewsWidgetTest.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldStorageDefinitionInterface. -------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/InlineEntityFormTest.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------ 418 | ERROR | [x] list(...) is forbidden, use [...] instead. ------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/PluginsTest.php ----------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------- 232 | WARNING | [x] 'TODO test if entities were selected. Will most likely need a custom event' should match the format '@todo Fix problem X here.' ----------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/EntityBrowserTest.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------------------- 44 | WARNING | [x] '@TODO Test the edit button.' should match the format '@todo Fix problem X here.' 183 | WARNING | [ ] Line exceeds 80 characters; contains 96 characters --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/EntityReferenceWidgetTest.php ----------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------------------- 607 | ERROR | [x] list(...) is forbidden, use [...] instead. ----------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/FieldWidgetConfigTest.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 157 | WARNING | Line exceeds 80 characters; contains 104 characters ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/FunctionalJavascript/CardinalityTest.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 244 | WARNING | Line exceeds 80 characters; contains 82 characters 322 | WARNING | Line exceeds 80 characters; contains 82 characters ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/Functional/EntityBrowserUITest.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 37 | ERROR | Public method name "EntityBrowserUITest::testEntityBrowserUI" is not in lowerCamel format ------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/tests/src/Functional/FormElementTest.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 73 | ERROR | The array declaration extends to column 151 (the limit is 120). The array content should be split up over multiple lines 73 | ERROR | The array declaration extends to column 150 (the limit is 120). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/entity_browser.api.php --------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES --------------------------------------------------------------------------------------------------------------- 14 | WARNING | Line exceeds 80 characters; contains 92 characters 24 | WARNING | Line exceeds 80 characters; contains 91 characters 34 | WARNING | Line exceeds 80 characters; contains 88 characters 44 | WARNING | Line exceeds 80 characters; contains 99 characters 54 | WARNING | Line exceeds 80 characters; contains 103 characters 65 | WARNING | Line exceeds 80 characters; contains 101 characters --------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/modules/entity_form/entity_browser_entity_form.module ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------- 11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldDefinitionInterface. 32 | WARNING | [x] 'TODO - 'default' might become configurable or something else in the future.' should match the format '@todo Fix problem X here.' 83 | WARNING | [x] 'TODO see if we can get away without overriding entire IEF function.' should match the format '@todo Fix problem X here.' 121 | WARNING | [x] 'TODO see if we can get away without overriding entire IEF function.' should match the format '@todo Fix problem X here.' ------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/modules/entity_form/src/Plugin/EntityBrowser/Widget/EntityForm.php ----------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------- 16 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityDisplayRepositoryInterface. 155 | ERROR | [ ] The array declaration extends to column 147 (the limit is 120). The array content should be split up over multiple lines 156 | ERROR | [ ] The array declaration extends to column 166 (the limit is 120). The array content should be split up over multiple lines ----------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/entity_browser.module -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 15 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface. 81 | ERROR | [ ] The array declaration extends to column 198 (the limit is 120). The array content should be split up over multiple lines 148 | ERROR | [x] list(...) is forbidden, use [...] instead. 166 | ERROR | [x] list(...) is forbidden, use [...] instead. -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Form/EntityBrowserEditForm.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\SubformState. 17 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name --------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Form/EntityBrowserForm.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 16 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Render\RendererInterface. ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/WidgetBase.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 332 | ERROR | [ ] Parameter $form_state is not described in comment 359 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Entity/EntityBrowser.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------- 323 | WARNING | [x] 'TODO - this doesn't make much sense. Refactor.' should match the format '@todo Fix problem X here.' 332 | WARNING | [x] 'TODO - this doesn't make much sense. Refactor.' should match the format '@todo Fix problem X here.' 386 | WARNING | [x] 'TODO: Allow displays to define more than just path.' should match the format '@todo Fix problem X here.' ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/WidgetInterface.php ---------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 78 | WARNING | Line exceeds 80 characters; contains 83 characters ---------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/DisplayInterface.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. ----------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php ------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------ 880 | WARNING | [x] 'TODO Figure out how to avoid using raw user input.' should match the format '@todo Fix problem X here.' ------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/FileBrowserWidget.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 304 | ERROR | [ ] The array declaration extends to column 133 (the limit is 120). The array content should be split up over multiple lines 439 | ERROR | [x] Use null coalesce operator instead of ternary operator. 445 | ERROR | [ ] The array declaration extends to column 129 (the limit is 120). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/Widget/Upload.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 65 | ERROR | The array declaration extends to column 177 (the limit is 120). The array content should be split up over multiple lines 120 | WARNING | Line exceeds 80 characters; contains 81 characters ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/Widget/View.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES ------------------------------------------------------------------------------------------------------------------------------------------------- 67 | WARNING | [x] 'TODO - do we need better error handling for view and view_display (in' should match the format '@todo Fix problem X here.' 82 | ERROR | [x] Use null coalesce operator instead of ternary operator. 108 | ERROR | [ ] The array declaration extends to column 149 (the limit is 120). The array content should be split up over multiple lines 109 | ERROR | [ ] The array declaration extends to column 130 (the limit is 120). The array content should be split up over multiple lines 110 | ERROR | [ ] The array declaration extends to column 127 (the limit is 120). The array content should be split up over multiple lines 236 | ERROR | [ ] The array declaration extends to column 170 (the limit is 120). The array content should be split up over multiple lines 271 | WARNING | [ ] ViewEntity::load calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/FieldWidgetDisplay/RenderedEntity.php ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------- 58 | ERROR | [x] Expected 1 space after "?"; 2 found 59 | ERROR | [x] Expected 1 space after ":"; 2 found ------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/FieldWidgetDisplay/ImageThumbnail.php ------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------- 53 | ERROR | [x] Expected 1 space after "?"; 2 found 54 | ERROR | [x] Expected 1 space after ":"; 2 found ------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/WidgetSelector/Tabs.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. ----------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/WidgetSelector/DropDown.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/WidgetSelector/Single.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/SelectionDisplay/View.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Entity\View. 41 | WARNING | [x] 'TODO - do we need better error handling for view and view_display' should match the format '@todo Fix problem X here.' 52 | WARNING | [x] 'TODO - if there are entities that are selected multiple times this' should match the format '@todo Fix problem X here.' 93 | ERROR | [ ] The array declaration extends to column 146 (the limit is 120). The array content should be split up over multiple lines 116 | ERROR | [x] list(...) is forbidden, use [...] instead. ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/Display/Modal.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Ajax\AjaxResponse. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/EntityBrowser/Display/Standalone.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 48 | WARNING | [ ] Possible useless method overriding detected 50 | WARNING | [x] '@TODO Implement it.' should match the format '@todo Fix problem X here.' 57 | WARNING | [x] '@TODO Implement it.' should match the format '@todo Fix problem X here.' ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Plugin/views/display/EntityBrowser.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 133 | ERROR | [x] Use null coalesce operator instead of ternary operator. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Element/EntityBrowserElement.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------ 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface. 257 | ERROR | [x] list(...) is forbidden, use [...] instead. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/SelectionDisplayBase.php ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface. 133 | ERROR | [ ] The trigger_error message 'checkPreselectionSupport method is deprecated. Use supportsPreselection instead.' does not match the relaxed standard format: %thing% is deprecated in | | %deprecation-version% any free text %removal-version%. %extra-info%. See %cr-link% ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/SelectionDisplayInterface.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 69 | ERROR | The text '@deprecated Use ::supportsPreselection instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. 69 | ERROR | Each @deprecated tag must have a @see tag immediately following it ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/EntityBrowserInterface.php ----------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ----------------------------------------------------------------------------------------------------------------------- 53 | ERROR | Parameter $widget_selector is not described in comment 56 | ERROR | Doc comment for parameter $display does not match actual variable name $widget_selector 64 | ERROR | Parameter $selection_display is not described in comment 67 | ERROR | Doc comment for parameter $display does not match actual variable name $selection_display ----------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/WidgetSelectorBase.php ------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------ 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 28 | ERROR | [ ] Class property $widget_ids should use lowerCamel naming without underscores 43 | ERROR | [x] Use null coalesce operator instead of ternary operator. ------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Events/Events.php -------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 7 LINES -------------------------------------------------------------------------------------------------------------------- 12 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 19 | WARNING | Line exceeds 80 characters; contains 82 characters 20 | WARNING | Line exceeds 80 characters; contains 85 characters 20 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 27 | WARNING | Line exceeds 80 characters; contains 82 characters 29 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 36 | WARNING | Line exceeds 80 characters; contains 81 characters 37 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph -------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Events/EventBase.php ----------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------- 45 | ERROR | Public method name "EventBase::getBrowserID" is not in lowerCamel format 55 | ERROR | Public method name "EventBase::getBrowserInstanceUUID" is not in lowerCamel format ----------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Events/EntitySelectionEvent.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 35 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Controllers/EntityBrowserFormController.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 107 | WARNING | [x] Inline @var declarations should use the /** */ delimiters 109 | WARNING | [x] Inline @var declarations should use the /** */ delimiters ---------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Controllers/EntityBrowserListBuilder.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------- 33 | WARNING | [x] Inline @var declarations should use the /** */ delimiters ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Controllers/EntityBrowserController.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 77 | ERROR | The array declaration extends to column 237 (the limit is 120). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/RouteSubscriber.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------- 50 | WARNING | [x] The variable name should be defined after the type 66 | ERROR | [ ] Protected method name "RouteSubscriber::getBrowserIDsWithRoute" is not in lowerCamel format ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Ajax/SelectEntitiesCommand.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 9 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph --------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/Ajax/ValueUpdatedCommand.php ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 17 | ERROR | Class property $details_id should use lowerCamel naming without underscores ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/vinmayi.nidubrolu/projects/drupal103x/drupal/modules/contrib/entity_browser/src/DisplayBase.php --------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Plugin\ContainerFactoryPluginInterface. --------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------- Time: 1.96 secs; Memory: 20MBMoving to NW.
Thanks!
- Status changed to RTBC
about 2 months ago 11:56am 10 July 2024 - 🇮🇳India VinmayiSwamy
I see there is another issue created for phpcs for the same version here - Fix the issues reported by phpcs 📌 Fix the issues reported by phpcs Needs review .
Hence, +1 to RTBC.
Thanks!
- Status changed to Needs work
about 2 months ago 8:39am 14 July 2024 - 🇨🇭Switzerland Berdir Switzerland
Contributions must be done as merge requests now, especially coding standards.