- Issue created by @Anybody
- last update
over 1 year ago 5 pass - @anybody opened merge request.
- Status changed to Needs review
over 1 year ago 3:37pm 12 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Gave this a first shot. If AdamPS is fine with the general approach, we need to add tests. Setting to NR for now to get initial feedback on the request.
- 🇬🇧United Kingdom adamps
Thanks for the idea and patch.
I believe the changes to
symfony_mailer_theme()
aren't needed. So anyone who wants this could already do it by adding their own preprocess function, containing a single line of code.However it's easy to do in the module also, so I'm open to the idea if there is support. How about if we wait a little and see if anyone else comments asking for it?
The thing is, subject where available in swiftmailer and I guess many sites used this as as heading in the mailtext in addition to the mail subject.
So +1 for the idea, this will make the migration a little easier.
- 🇩🇪Germany Grevil
I agree providing the subject would make sense for BC with Swiftmailer and shouldn't need an extra hook, I think. Useful addition for all. Thanks!
- Status changed to Needs work
over 1 year ago 2:21pm 15 June 2023 - 🇬🇧United Kingdom adamps
Great then let's do it.
As per #6, please try removing the changes to
symfony_mailer_theme()
. - last update
over 1 year ago 5 pass - 🇩🇪Germany Anybody Porta Westfalica
Thanks @AdamPS, I removed the changes from symfony_mailer_theme(), still I found them helpful to see the available variables.
So we should instead document them in the twig file. I didn't have the time to test it, so let's keep this NW for these final TODOs.
- last update
over 1 year ago 5 pass - Status changed to Needs review
over 1 year ago 9:18am 19 June 2023 - last update
over 1 year ago 5 pass - 🇩🇪Germany Grevil
Here is the test output:
With the following code overwritten in the "email-wrap.html.twig":
Subject: "<strong>{{ subject }}</strong>" <br /> Body: "{{ body }}"
- Status changed to RTBC
over 1 year ago 9:34am 19 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Perfect, confirming the manual test. Don't think we need a further automated test here?
- last update
over 1 year ago 5 pass - Status changed to Fixed
over 1 year ago 9:55am 19 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Thank YOU @AdamPS! Cool to see this merged :) Helps me a lot with many projects.
Automatically closed - issue fixed for 2 weeks with no activity.