- Issue created by @dave reid
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
+1!
@Dave Reid, @lauriii and I discussed this at DrupalCon Pittsburgh.
- last update
over 1 year ago Custom Commands Failed - @dave-reid opened merge request.
- Status changed to Needs review
over 1 year ago 3:33pm 17 June 2023 - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - last update
over 1 year ago 29,499 pass - Status changed to Needs work
over 1 year ago 5:05pm 17 June 2023 - 🇺🇸United States smustgrave
Change looks good, moving to NW for change record
As far as tests go I think I agree if the functionality is a 1 to 1 replacement (to be generic implementation) then it should be covered by maybe MediaEmbedFilterTest.
- Issue was unassigned.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Let's get this moving forward again. I wish I'd seen this ~9 months ago, then I'd have just written the change record that would've avoided this from lingering instead of landing 😞