- Issue created by @jayhuskins
- Assigned to Chester_
- last update
over 1 year ago 2 fail - @chesterr opened merge request.
- last update
over 1 year ago 2 fail - Status changed to Needs review
over 1 year ago 1:05pm 26 June 2023 - last update
over 1 year ago 2 fail - 🇺🇸United States jayhuskins
@Chesterr I'm a little confused looking at how the new settings in your MR are applied.
In
src/LayoutBuilderLock.php
you have this comment:> If 'Disable bypass everywhere' and 'Add ability to override lock bypass' are enabled, allow the user to bypass locks.
Why would the user be allowed to bypass a lock if "Disable bypass" is enabled? Shouldn't it be the opposite?
@jayhuskins Hi, maybe I didn't understand your task correctly. Or is the problem with the wrong comment?
But for now, if we enable the checkboxes on the configuration page, and on our form in the layout builder, we will allow bypassing wherever the checkboxes in the layout builder are enabled. I thought this was an interesting feature as we can enable a checkbox on the configuration page and if we have many layouts with different accesses we can bypass them all.
- 🇺🇸United States jayhuskins
Oh interesting I think we're using "bypass" to mean opposite things.
- My interest was in configuring a section so that even the "user 1" administrator can't modify a locked block.
- If I correctly understand you and your code, it seems you are building a configuration to allow anyone to modify a locked block.
Both features would be valuable, so we should split this into two issues.
- Status changed to Needs work
over 1 year ago 8:11pm 3 July 2023 - 🇺🇦Ukraine Panchuk Volyn, Lutsk
We will be able to merge this feature into the development branch after fixes for merge requests and tests update.
- last update
over 1 year ago 2 fail - Status changed to Needs review
over 1 year ago 10:15am 17 July 2023 Hi, I tried to fix the problems you pointed out, are the problems still there?
- last update
over 1 year ago 2 fail - last update
over 1 year ago 2 fail - Status changed to Needs work
over 1 year ago 1:12pm 17 July 2023 - 🇺🇦Ukraine Panchuk Volyn, Lutsk
Still minor issues present and still need tests.
- Issue was unassigned.
- Status changed to Postponed
11 months ago 10:46am 17 December 2023 - 🇺🇦Ukraine Panchuk Volyn, Lutsk
The feature looks fine, but I'm not sure if somebody needs it. Added the 'postponed' status for now.