Drupal 9 & 10 compatibility and PHPCS fixes

When installing, the warning

You have requested a non-existent service "subman.sync".

will appear. Unfortunately, this can not be currently fixed. As any module using subman, has to implement a "subman.sync" service. The "subman.sync" service declared in subman is only an abstract class with the method declarations. This surely isn't the way on how to declare services, but without major refactoring, this isn't fixable. BUT doesn't break the module as long, as a module as "billwerk" is installed.

@Anybody, I stopped fixing PHPCS issues, as there are just way too many of them...

Please mainly review https://git.drupalcode.org/issue/subman-3364484/-/commit/4a3f981c015827f.... Where the actual compatibility fixes got implemented.

I created an issue for the remaining phpcs issues here: 📌 Fix the remaining Drupal PHPCS issues Closed: won't fix

I will test the module in conjunction with billwerk now under Drupal 10.

I also added an issue for the problem mentioned in #3, see 🐛 Error: You have requested a non-existent service "subman.sync" Fixed .

@Grevil: Well done. Just some comments to fix, RTBC afterwards :)

Done, please review once again and make sure to review the changes in https://git.drupalcode.org/project/subman/-/merge_requests/1/diffs?commi..., as they probably got committed during review.

Last one!

Done

n1, LGTM!

Automatically closed - issue fixed for 2 weeks with no activity.