- Issue created by @Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Thank you, we should take a look at this together. I'd be even happier to hear from @danielnolde about the idea behind.
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Assigning to you as reminder.
- 🇩🇪Germany Anybody Porta Westfalica
This is definitely a misconception in the module, as the "subman" module is a dependency of the implementing modules, like "Billwerk". To install Billwerk, it's required to install Subman, which isn't possible due to this error.
So whatever is the reason here, has to be reengineered or fixed.
- Status changed to Needs work
almost 2 years ago 8:32am 27 June 2023 - 🇩🇪Germany Grevil
Ok, this is not easy to figure out.
First thought, was to define the subman.sync service in subman and mark it as an abstract service. But subman calls the services internally, and we can not instantiate an abstract service. Furthermore instantiating the billwerk service directly in subman wouldn't make sense at all.
My next thought was, to flag the service as "syntetic", so we would instantiate it during runtime, ONLY when billwerk is already installed: https://symfony.com/doc/current/service_container/synthetic_services.html. But this would lead to a hard dependency on billwerk inside subman, which we do not want (since it is the other way around). - Issue was unassigned.
- 🇩🇪Germany Grevil
I'd say this needs some major refactor, otherwise we could simply ignore the error, since it is installable (although errors get thrown).
- Assigned to Grevil
- 🇩🇪Germany Anybody Porta Westfalica
We need to use service decoration here, I think. subman.sync service should *never* be defined in Billwerk. That's the wrong namespace.
See:
https://www.previousnext.com.au/blog/decorated-services-drupal-8 - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - @grevil opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:32am 27 June 2023 - 🇩🇪Germany Grevil
Done, works great with the changes in 🐛 Installation error: ServiceNotFoundException: You have requested a non-existent service "subman.sync" Fixed !
Please review.
- Status changed to RTBC
almost 2 years ago 9:44am 27 June 2023 - 🇩🇪Germany Anybody Porta Westfalica
Well done! Merging in combination with 🐛 Installation error: ServiceNotFoundException: You have requested a non-existent service "subman.sync" Fixed
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8last update
almost 2 years ago Waiting for branch to pass - Status changed to Fixed
almost 2 years ago 10:03am 27 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.