- Issue created by @djween
- Status changed to Needs review
about 1 year ago 11:49am 5 June 2023 - 🇮🇳India KarthickAcsh_R coimbatore
A argument missing in the "CartEventSubscriber", Updated in the patch.
- 🇫🇷France Toki Caen, Normandy
This is a critical issue in my opinion since no one can order because of that (I got the exact same issue with wsod).
I have just patched the module with #2 (but without the use on line 8 since there is already a call to EntityTypeManager) and it seems OK now. - 🇨🇦Canada simgui8 Canada
- 🇫🇷France Toki Caen, Normandy
My mistake, I have edited manually the file on PHPStorm.
After adding the modifications line 31, use lines have been added automatically.
With my manual add on EntityTypeManager, I got an error message on drush about an "use" already done.
So the patch is completely fine! - Merge request !12Issue #3364476: after upgrading to Commerce Core 8.x-2.36 this module doesn't work → (Open) created by simgui8
- 🇺🇸United States dobe
Just ran into this on a production site. #2 resolved my issue! Thank you!
- Status changed to RTBC
12 months ago 1:17pm 3 July 2023 thank you for the patch. it applies cleanly to version 1.9 and resolves this issue. marking as RTBC.
- 🇩🇪Germany mericone
Thank you for this valuable patch. You might have to replace template files, if you use your own theme, otherwise you might not see any output at all.
- 🇬🇧United Kingdom guy_schneerson
Tested with:
- Core: 9.5.10
- Commerce: 8.x-2.36
The merge request !12 by @simgui8 works and is essential for working with the latest version of commerce CommerceCartEventSubscriber and should ideally be committed for supporting a smother Drupal 10 upgrade path.
For anyone needing to get their site ready beforehand, you can add it as a patch to your composer.json
"patches": { "drupal/commerce_cart_flyout": { "after upgrading to Commerce Core 8.x-2.36 this module doesn't work": "https://git.drupalcode.org/project/commerce_cart_flyout/-/merge_requests/12.patch" } } - 🇳🇱Netherlands Neograph734 Netherlands
This patch no longer applied for me. It appears that the same changes have now been made in the pull request in 📌 Drupal 10 support Needs work . (But my cart still does not load...)
- First commit to issue fork.
- 🇦🇺Australia ELC
The
$messengerand$entityTypeManagerproperties are defined and set in the parent CommerceCartEventSubscriber, hence the
parent::__construct($messenger, $string_translation, $entity_type_manager);
No need for ST trait when TranslationInterface already injected, plus it's a parent issue.This change has been included in 📌 Drupal 10 support Needs work .
Cart not loading is some change inside flyout, in that issue. In D9, it still works with 8.x-1.9 + this commit.
- 🇩🇪Germany Anybody Porta Westfalica
Should this perhaps better be closed as duplicate of 📌 Drupal 10 support Needs work which seems more complete?
- Status changed to Closed: duplicate
5 months ago 7:20pm 16 January 2024 - 🇩🇪Germany Hydra
It surly is. Haven't seen this since the D10 upgrade of the project I used this for is still tbd. So yeah thx Anybody, lets focus on the other issue. The patch works as a workaround and needs to be upgraded to the other issue anyways. So lets close this.