Tighten CKEditor 5 kernel tests

Created on 2 June 2023, over 1 year ago
Updated 5 July 2023, over 1 year ago

Problem/Motivation

📌 KernelTestBase::$strictConfigSchema = TRUE and BrowserTestBase::$strictConfigSchema = TRUE do not actually strictly validate Fixed is updating \Drupal\Tests\SchemaCheckTestTrait::assertConfigSchema() to also run validation.

This surfaced a few problems in the existing CKEditor 5 kernel tests, because they are only validating the results of configuration transformations made by the CKEditor 5 module, they're not testing the initial configuration provided by data providers.

Steps to reproduce

See first commit to MR.

Proposed resolution

  1. Explicitly do validation in CKEditor 5 tests in the select few places that 📌 KernelTestBase::$strictConfigSchema = TRUE and BrowserTestBase::$strictConfigSchema = TRUE do not actually strictly validate Fixed surfaced bugs in. Add @todo to remove these again in #3361534.
  2. Fix tests.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

📌 Task
Status

Fixed

Version

11.0 🔥

Component
CKEditor 5 

Last updated about 11 hours ago

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024