Warning: Undefined array key "#access" in language_form_alter()

Open on Drupal.org →

Created on 2 June 2023, almost 2 years ago

Updated 12 September 2024, 7 months ago

Problem/Motivation

Sometimes $form[$langcode_key]['#access'] can be undefined and is better to check if it exists and not just if $form[$langcode_key] is defined.

Sometimes I get this error on my sites:
Warning: Undefined array key "#access" in language_form_alter() (line 370 of core/modules/language/language.module).

And with a simple validation, we can fix this.

Steps to reproduce

Is hard to say how this happens but I thin a better check on the if can fix this without any additional problems.

Proposed resolution

Change the validation from:

    if (isset($form[$langcode_key]) && $form[$langcode_key]['#access'] !== FALSE) {
      $language_configuration = ContentLanguageSettings::loadByEntityTypeBundle($entity->getEntityTypeId(), $entity->bundle());
      $form[$langcode_key]['#access'] = $language_configuration->isLanguageAlterable();
    }

to:

    if (isset($form[$langcode_key]['#access']) && $form[$langcode_key]['#access'] !== FALSE) {
      $language_configuration = ContentLanguageSettings::loadByEntityTypeBundle($entity->getEntityTypeId(), $entity->bundle());
      $form[$langcode_key]['#access'] = $language_configuration->isLanguageAlterable();
    }

Remaining tasks

Review the patch.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Language system →

Last updated about 2 hours ago

Maintained by
🇩🇪Germany @sun

Created by

🇨🇦Canada adriancid Montreal, Canada

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Sign in to follow issues

Merge Requests

!9466Warning: Undefined array key "#access" in language_form_alter()
Open
🇮🇳India anandhi karnan
updated 7 months ago
!4098Warning: Undefined array key "#access" in language_form_alter()
Open
🇨🇦Canada adriancid
updated 7 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Issue created by @adriancid
Merge request !4098Issue #3364343: Warning: Undefined array key "#access" in language_form_alter() → (Open) created by adriancid
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
30,335 pass
Status changed to Needs review almost 2 years ago3:17am 2 June 2023
Comment almost 2 years ago →
🇨🇦Canada adriancid Montreal, Canada
Status changed to Needs work almost 2 years ago2:38pm 2 June 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Seems like a bug that will need a test case showing the issue.
Comment over 1 year ago →
🇩🇪Germany donquixote
I think I have a better idea how this happens.

Normally, the $form['langcode'] is added by EntityFormDisplay::buildForm(), as a component.
Here the ['#access'] is set for every component.

However, when using a custom form handler, perhaps for a custom entity type, perhaps the 'langcode' element is added in the form builder itself. In that case, if the developer does not set the '#access', they will see this message.

So the blame could be on the developer who creates a custom entity form. But it is also not clear what is the "contract" for adding this element in a custom form.

@adriancid Do you know which entity and which form this is?
Comment 7 months ago →
🇬🇷Greece vensires
I fell into this issue while tampering the node form's $form['langcode']['widget'] without checking if it exists. @donquixote's comment helped me identify this. After I added my code in a if (isset($form['langcode']['widget'])) {... } the error was gone.

So, I am coming back with the question of... do we really want to fix this? I don't have a clear answer on that...
Comment 7 months ago →
🇮🇳India anandhi karnan Chennai
anandhi karnan → made their first commit to this issue’s fork.
Merge request !9466issue #3364343 Warning: Undefined array key #access in language_form_alter → (Open) created by anandhi karnan
Comment 7 months ago →
🇮🇳India anandhi karnan Chennai
MR for Drupal 11.x
Status changed to Needs review 7 months ago10:12am 11 September 2024
Comment 7 months ago →
🇮🇳India anandhi karnan Chennai
Status changed to Needs work 7 months ago2:31pm 11 September 2024
Comment 7 months ago →
🇺🇸United States smustgrave
Think before we just put an isset check we document why it's empty and verify aren't masking a larger issue.
Comment 7 months ago →
🇮🇳India anandhi karnan Chennai
@smustgrave The warning "Undefined array key '#access'" is difficult to reproduce in environments where the #access key is consistently set. Consequently, the warning does not typically manifest under standard conditions. However, it is important to address this issue to adhere to strict coding standards and ensure robust error handling.
Comment 7 months ago →
🇺🇸United States smustgrave
Making an error go away without knowing the root cause doesn’t seem right.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024