- Issue created by @alison
- ๐ณ๐ฟNew Zealand quietone
That was meant to be the parent, not related
- Status changed to Needs review
about 1 year ago 10:32am 23 October 2023 - last update
about 1 year ago Patch Failed to Apply - ๐ฎ๐ณIndia _utsavsharma
Added queueing to dictionary.txt and changed its occurrence in the remaining files.
- Status changed to Active
about 1 year ago 11:45am 23 October 2023 - ๐ณ๐ฟNew Zealand quietone
@_utsavsharma, thank you for your interest in spelling issue. Before uploading a patch it is good practice to make sure that it applies locally. Also, spelling issues often require the rebuilding of the dictionary so I recommend reading the parent issue of this one. Cheers!
I am setting this to active because we need to decide which spelling or spellings we want to use in Drupal before patching. Also, this patch is adding a word to the Drupal dictionary which already existing in the en_us dictionary.
- ๐ฎ๐ณIndia pragati_kanade Pune
Above Patch looks good to me. All "queuing" replace with recommended spell "queueing".
- Status changed to RTBC
about 1 year ago 8:20am 5 December 2023 - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs work
about 1 year ago 8:25am 5 December 2023 The Needs Review Queue Bot โ tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request โ . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Active
11 months ago 8:19am 8 February 2024 - ๐ณ๐ฟNew Zealand quietone
@pragati_kanade, the previous comment set this issue to Active because there has not really been enough discussion on the choice of spelling.
- ๐บ๐ธUnited States dww
+1 to "queueing" as the "correct" spelling, even though there's some indication that that's the "British" way of spelling it, while the version with 1 'e' is more "American".
British
https://www.oed.com/dictionary/queueing_adj
American
https://www.collinsdictionary.com/us/dictionary/english/queuing
https://www.merriam-webster.com/dictionary/queuingYet every one of those pages list both versions as correct. So it seems very subjective.
So I think the bikeshed should be painted "queueing". ๐
Cheers,
-Derek - ๐ฎ๐ณIndia urvashi_vora Madhya Pradesh, India
+1 for "Queueing", although both the spellings mean the same but going with the longer one.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
So I think the bikeshed should be painted "queueing".
Haha ๐
Queue + ing
Seems the most logical for me as well. That's how I, as a non native English speaking person would write it. - ๐ฌ๐งUnited Kingdom jonathan1055
+1 for the full longer version queueing
Queue + ing Seems the most logical for me as well. That's how I, as a non native English speaking person would write it.
That is a good point, thanks.
Six people here agree with the longer version and no-one has wanted the shorter version. So that seems like we have reached an agreement.
- Status changed to Needs review
11 months ago 9:24am 10 February 2024 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Updated patch to MR (and rebased). Also reverted the change in the core/vendor directory as I'm not sure we should be changing that.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Spellcheck output.
gitpod /workspace/DrupalPod/repos/drupal/core (3364292-spelling-queueing) $ ddev yarn run -s spellcheck:core --no-must-find-files --no-progress CSpell: Files checked: 15303, Issues found: 0 in 0 files
- Status changed to Needs work
11 months ago 9:44am 10 February 2024 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Just realised the patch is not how it should be fixed. My bad. Will update to what is suggested in the IS.
- Status changed to Needs review
11 months ago 9:53am 10 February 2024 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Updated to the correct implementation.
New cspell output.
gitpod /workspace/DrupalPod/repos/drupal/core (3364292-spelling-queueing) $ ddev yarn run -s spellcheck:core --no-must-find-files --no-progress CSpell: Files checked: 15303, Issues found: 0 in 0 files
- Status changed to RTBC
11 months ago 11:04pm 10 February 2024 - ๐บ๐ธUnited States dww
GitLab CI won't really understand what "test-only" means here. ๐ So I just applied the change to the
flagWords
incore/.cspell.json
and ranyarn run -s spellcheck:core
. The only error I got was:./core/lib/Drupal/Core/Database/Query/SelectInterface.php:331:42 - Forbidden word (queuing)
So flagWords is working as expected. The full pipeline is green, since that is fixed here in the MR.
The summary is clear and complete. I'm updating the title to try to be more appropriate for a commit message.
The MR is all good. This is ready.
Thanks!
-Derek - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
There is a test only run that you can trigger in GitLab CI ๐
- ๐บ๐ธUnited States dww
Indeed, Iโm very familiar with that job and how it works. Iโm helping to get it ported into the contrib templates. #3418831: Test-only job โ . Thatโs why I said it would not help for this issue and why I did a โtest-onlyโ approach manually to make it easier for committers. ๐
-
quietone โ
committed c574a6e4 on 11.x
Issue #3364292 by BramDriesen, dww, alison, cilefen, jonathan1055,...
-
quietone โ
committed c574a6e4 on 11.x
-
quietone โ
committed 73c1387c on 10.2.x
Issue #3364292 by BramDriesen, dww, alison, cilefen, jonathan1055,...
-
quietone โ
committed 73c1387c on 10.2.x
- Status changed to Fixed
11 months ago 7:21am 12 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.