dictionary: queueing vs. queuing

+1 for "queueing", same reasons.

That was meant to be the parent, not related

Added queueing to dictionary.txt and changed its occurrence in the remaining files.

@_utsavsharma, thank you for your interest in spelling issue. Before uploading a patch it is good practice to make sure that it applies locally. Also, spelling issues often require the rebuilding of the dictionary so I recommend reading the parent issue of this one. Cheers!

I am setting this to active because we need to decide which spelling or spellings we want to use in Drupal before patching. Also, this patch is adding a word to the Drupal dictionary which already existing in the en_us dictionary.

Above Patch looks good to me. All "queuing" replace with recommended spell "queueing".

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

@pragati_kanade, the previous comment set this issue to Active because there has not really been enough discussion on the choice of spelling.

+1 to "queueing" as the "correct" spelling, even though there's some indication that that's the "British" way of spelling it, while the version with 1 'e' is more "American".

British

https://www.oed.com/dictionary/queueing_adj

American

https://www.collinsdictionary.com/us/dictionary/english/queuing
https://www.merriam-webster.com/dictionary/queuing

Yet every one of those pages list both versions as correct. So it seems very subjective.

So I think the bikeshed should be painted "queueing". 😂

Cheers,
-Derek

+1 for "Queueing", although both the spellings mean the same but going with the longer one.

So I think the bikeshed should be painted "queueing".

Haha 😂

Queue + ing Seems the most logical for me as well. That's how I, as a non native English speaking person would write it.

+1 for the full longer version queueing

Queue + ing Seems the most logical for me as well. That's how I, as a non native English speaking person would write it.

That is a good point, thanks.

Six people here agree with the longer version and no-one has wanted the shorter version. So that seems like we have reached an agreement.

Thanks everyone!

Updated patch to MR (and rebased). Also reverted the change in the core/vendor directory as I'm not sure we should be changing that.

Spellcheck output.

gitpod /workspace/DrupalPod/repos/drupal/core (3364292-spelling-queueing) $ ddev yarn run -s spellcheck:core --no-must-find-files --no-progress
CSpell: Files checked: 15303, Issues found: 0 in 0 files

Just realised the patch is not how it should be fixed. My bad. Will update to what is suggested in the IS.

Updated to the correct implementation.

New cspell output.

gitpod /workspace/DrupalPod/repos/drupal/core (3364292-spelling-queueing) $ ddev yarn run -s spellcheck:core --no-must-find-files --no-progress
CSpell: Files checked: 15303, Issues found: 0 in 0 files

GitLab CI won't really understand what "test-only" means here. 😂 So I just applied the change to the flagWords in core/.cspell.json and ran yarn run -s spellcheck:core. The only error I got was:

./core/lib/Drupal/Core/Database/Query/SelectInterface.php:331:42 - Forbidden word (queuing)

So flagWords is working as expected. The full pipeline is green, since that is fixed here in the MR.

The summary is clear and complete. I'm updating the title to try to be more appropriate for a commit message.

The MR is all good. This is ready.

Thanks!
-Derek

There is a test only run that you can trigger in GitLab CI 😉

Indeed, I’m very familiar with that job and how it works. I’m helping to get it ported into the contrib templates. #3418831: Test-only job → . That’s why I said it would not help for this issue and why I did a “test-only” approach manually to make it easier for committers. 👍

Committed c574a6e and pushed to 11.x. Cherry picked to 10.2.x to keep dictionary in sync and there are no code changes here.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

bramdriesen → closed merge request !6536