- Issue created by @urvashi_vora
- Status changed to Needs work
over 1 year ago 12:42pm 29 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ * This module extendeds functionality of core messenger to handle situations + when you want to leave a specific user with warning/error/info message on + login event.
Since that sentence is part of a list, the part that is moved on a new line must be intended. extendeds is also misspelled.
- Assigned to urvashi_vora
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:49pm 29 May 2023 - Status changed to Needs work
over 1 year ago 3:11pm 29 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- * i think this module can be more developed to not just leave a message on login but also on page refresh but i didn't check on performance if did so and admin may leave a custom warning for specific user through a form. if you have an idea to extend, you're more than welcomed to create an issue. + * I think this module can be more developed to not just leave a message on + login but also on page refresh but i didn't check on performance if did so + and admin may leave a custom warning for specific user through a form. + If you have an idea to extend, you're more than welcomed to create an issue.
Since that text is changed, also the misspelled words and the punctuation needs to be corrected. (The first person singular is spelled I, not i.)
- * i.e. if system has applied an action against a user or any data related to him/her and want to let know what happened beside any other notification method. + * i.e. if system has applied an action against a user or any data related + to him/her and want to let know what happened beside any other notification + method.
There some changes to be done on that text, but let's just remove i.e. which is not used before an example. let needs a pronoun; it is better to change user with users, so there is no need to say him/her, and the pronoun after let is easier to get it.
- * When a new private messenger message entity is created, set the uid entity reference to - * the current user as the creator of the entity. + * When a new private messenger message entity is created, + * set the uid entity reference to the current user as the creator + * of the entity.
- * You need to create an private messenger entity whenever needed and module will load this entity on login and show message and remove the entity to not flood its table. in future i will add a simpler method to send the message. + * You need to create an private messenger entity whenever needed and module + will load this entity on login and show message and remove the entity to not + flood its table. + In future, planned to implement a simpler method to send the message.
The length of lines should be close as much as possible to 80 characters, as long as to make them 80 characters, a word is not split in two different lines. Lines are not split at punctuation marks. All the text after the changed one needs to be reformatted.
In future, planned to implement a simpler method to send the message. is not grammatically correct. (The subject is missing.) - Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:09am 30 May 2023 - 4cbfd3ba committed on 1.x
fixed coding standard issues #3363331
- 4cbfd3ba committed on 1.x
- Status changed to Fixed
over 1 year ago 8:57am 6 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.