Remove composer.lock and vendor directory from h5p

Created on 26 May 2023, about 1 year ago
Updated 9 February 2024, 5 months ago

Problem/Motivation

This causes unforeseen conflicts with composer installs

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Closed: duplicate

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States SocialNicheGuru

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @SocialNicheGuru
  • πŸ‡¬πŸ‡§United Kingdom catch

    Bumping to major. I've just committed πŸ“Œ Allow update to H5P editor/core 1.25 Fixed to allow composer installs to move to H5P 1.25 for PHP 8.0 compatibility, but that leaves the site vendor directory and the one in this module out of sync.

    The h5p module uses css/js from /vendor so this isn't as easy as deleting the directories altogether. What about adding a script to the project to delete the PHP files, then this could run each time /vendor is updated?

  • πŸ‡¨πŸ‡¦Canada ShaunDychko

    The /h5p/vendor/ directory can't really be deleted since not only are so many CSS and JS files referenced in code, but it's also in the resize JS link in embeds, so removing it would somewhat break other sites that have embedded an H5P. Also, the composer.json needs to lock down a specific version of the dependencies in order to have a match between the dependencies included in the module's /vendor and the dependencies installed by composer in the project's root /vendor. The patch in πŸ› Support h5p/h5p-core:1.26 and h5p/h5p-editor:1.25 Needs work deletes the autoloader and all php files included in the module, and keeps the composer.lock file in order for the version installed in the project /vendor to match the CSS and JS shipped with the module's /vendor directory.

  • Status changed to Closed: duplicate 5 months ago
Production build 0.69.0 2024