- Issue created by @prudloff
- Merge request !4056Issue #3362917: TranslationLanguageRenderer adds langcode field to query even if corresponding value field is not added β (Open) created by prudloff
- last update
almost 2 years ago 30,324 pass, 10 fail - Status changed to Needs review
almost 2 years ago 9:51am 26 May 2023 - Status changed to Needs work
almost 2 years ago 11:46pm 29 May 2023 - πΊπΈUnited States smustgrave
Have not yet reviewed
But fix seemed to cause some failures.
Also will need it's own test case.
Should also try and aim for 11.x as that's the current development branch.
- π«π·France prudloff Lille
prudloff β changed the visibility of the branch 3362917-translationlanguagerenderer-adds-langcode to hidden.
- π«π·France prudloff Lille
Calling
$this->getEntityFieldRenderer()->query()
seems necessary because it does not only add the GROUP BY, it also adds the langcode in SELECT so the entity can be rendered in the correct language.And I can't reproduce the duplicate problem from the issue summary so I'm closing this.
I'll reopen if I manage to reproduce. - π«π·France prudloff Lille
I managed to reproduce my original duplicate problem and I think π Views entity reference relationships must join on langcode for translatable entities Needs review would be the correct way to fix this.