renderPager() in DisplayPluginBase.php always return TRUE

Open on Drupal.org →

Created on 25 May 2023, over 1 year ago

Updated 3 August 2023, over 1 year ago

Problem/Motivation

While debugging an issue on our site, I noticed that the renderPager() function in DisplayPluginBase.php always return TRUE even if there is no pager to render. This eventually leads to a RuntimeException when search_api tries to render a node with a EVA display that has pager disabled. It seems unnecessary to render the disabled pager in the first place. For example, when the pager type is NONE or SOME, there is no need to render the pager at all.

Proposed resolution

Instead of returning TRUE all the time, it should return the result of "isPagerEnabled()".

🐛 Bug report

Status

Needs work

Version

9.5

Component

Last updated 1 day ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @tim.plunkett
🇬🇧United Kingdom @damiankloip
🇺🇸United States @xjm
🇳🇱Netherlands @Lendude

Created by

🇺🇸United States kevin w

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Issue created by @kevin w
Comment over 1 year ago →
🇺🇸United States kevin w
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,334 pass
Comment over 1 year ago →
🇺🇸United States JasonSafro
I came across this ticket while trying to solve the issue described in https://www.drupal.org/project/search_api/issues/3274158 🐛 RuntimeException while trying to render item Active . I applied the patch.

Bad news: This patch did not resolve https://www.drupal.org/project/search_api/issues/3274158 🐛 RuntimeException while trying to render item Active for me.
Good news: This patch did not cause any problems that I noticed. So that's something.
Status changed to Needs review over 1 year ago6:47pm 5 July 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
Patch Failed to Apply
Comment over 1 year ago →
🇮🇳India priya.chat
Hi, For this issue, we can put a condition to check whether a pager is in use or not and then return TRUE to FALSE value accordingly. I have created a patch for this issue resolution. Thanks.
Status changed to Needs work over 1 year ago7:12pm 5 July 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
As a bug will need a test case showing the issue.

Thanks.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.0 & MySQL 5.7 updated deps
last update over 1 year ago
Patch Failed to Apply
Comment over 1 year ago →
🇮🇳India suresh prabhu parkala Bangalore
Re-rolled the patch. Please review.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30,341 pass

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024