renderPager() in DisplayPluginBase.php always return TRUE

Created on 25 May 2023, about 1 year ago
Updated 3 August 2023, 11 months ago

Problem/Motivation

While debugging an issue on our site, I noticed that the renderPager() function in DisplayPluginBase.php always return TRUE even if there is no pager to render. This eventually leads to a RuntimeException when search_api tries to render a node with a EVA display that has pager disabled. It seems unnecessary to render the disabled pager in the first place. For example, when the pager type is NONE or SOME, there is no need to render the pager at all.

Proposed resolution

Instead of returning TRUE all the time, it should return the result of "isPagerEnabled()".

🐛 Bug report
Status

Needs work

Version

9.5

Component
Views 

Last updated about 2 hours ago

Created by

🇺🇸United States Kevin W

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024