Contrib.social

Is the hard coded provider scheme '/videos/watch/*' still correct?

Open on Drupal.org →
Created on 24 May 2023, almost 2 years ago
Updated 25 May 2023, almost 2 years ago

Problem/Motivation

We're running into issues with adding new Peertube oembed videos, saying "Could not retrieve the oEmbed resource.".

Having a look at the code and the Peertube documentation at https://docs.joinpeertube.org/api/embed-player is the hard-coded endpoint scheme still correct?

  /**
   * Function to get the peertube provider endpoint.
   *
   * @param string $provider_url
   *   The provider URL.
   *
   * @return array
   *   The provider endpoint representation.
   */
  public function getPeertubeEndpoint($provider_url) {
    return [
      'schemes' => [
        $provider_url . '/videos/watch/*',
      ],
      'url' => $provider_url . '/services/oembed',
      'discovery' => TRUE,
    ];
  }

Especially I'm wondering, if $provider_url . '/videos/watch/*', is still right, for example in our case it redirects to /w/ which *might* cause the issue, if curl doesn't follow redirects.

Does this part eventually need to be configurable? If there any documentation?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

💬 Support request
Status

Closed: works as designed

Version

2.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • Comment almost 2 years ago →
    🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺

    It might have changed in the latest versions of peertube. We might need to grab the version and then adapt the code to handle these different cases.
    I admit I didn't touch Peertube for a while so not sure what changes they introduced, I'll need to have a look.

    If you have ability the contribute a patch, that would be greatly appreciated.

  • Comment almost 2 years ago →
    🇩🇪Germany Anybody Porta Westfalica

    Thanks for the immediate reply @phjou. Sadly a customer just told us about the issues, but we're not administering their Peertube and I have no access. That makes things hard.

    Furthermore it's hard to find the root cause because of ✨ Improve oEmbed exception logging Needs work
    Please let me know if you have any further ideas. I'll also try to figure it out ...

    As first step to prevent us from human mistake, could you perhaps have a look at 📌 Add a "Peertube instances" domain name example & validation Fixed ?

  • Comment almost 2 years ago →
    🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺

    Sure I can definitely have a look at these issues, but I will most likely not have time until this weekend unfortunately.

  • Status changed to Closed: works as designed almost 2 years ago
  • Comment almost 2 years ago →
    🇩🇪Germany Anybody Porta Westfalica

    Just played around a bit and the hard coded URL still seems to work, at least with redirects. So we can keep this, I think. If the maintainer decides, this should better be configurable, please reopen.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024