- Issue created by @Anybody
- Status changed to Needs review
almost 2 years ago 2:58pm 24 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Maintainer: Could you please check if my assumption is correct or which kind of domain format is expected?
- 🇩🇪Germany Anybody Porta Westfalica
Looking at the code here: https://git.drupalcode.org/issue/peertube-3362469/-/blob/3362469-add-dom...
it seems the protocol might expected?
Would it then perhaps make sense to validate the entered URL to save users from issues with unexpected URL formats? - Merge request !4Issue #3362469: Add a "Peertube instances" domain name example & validation → (Merged) created by Anybody
- 🇩🇪Germany Anybody Porta Westfalica
After looking at the code and testing around, it's not clear, that the URL needs to include the scheme part, without trailing slash!
So a valid example is:https://www.mypeertubeurl.com
! - 🇩🇪Germany Anybody Porta Westfalica
Here we go finally. I improved the documentation and added validateForm() which checks the URLs for the expected format. Tested everything manually and it works perfectly fine.
Please review.
- Status changed to RTBC
almost 2 years ago 3:19pm 25 May 2023 - 🇨🇦Canada phjou Vancouver 🇨🇦 🇪🇺
Sorry for the delay, looks great.
Thank you for the merge request! - Status changed to Fixed
over 1 year ago 6:07pm 7 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.