Fix the issues reported by phpcs

The src/Plugin/Field/FieldFormatter/Image_field_360.php file has been deleted, but no other file has been added. The error shown in the report does not say that file must be removed; it says the class name must be changed.

Hi @apaderno,

For the feedback:

The src/Plugin/Field/FieldFormatter/Image_field_360.php file has been deleted, but no other file has been added. The error shown in the report does not say that file must be removed; it says the class name must be changed.

I appreciate your efforts in addressing the error regarding the class name and file naming convention. As per the error message, it was necessary to change the class name and subsequently rename the file to ensure that they match. I understand that during this process, the renamed file ended up being untracked in Git, while the deleted file remained tracked. Consequently, when checking the Git diff, only the deleted file was captured, excluding the changes made to the renamed file.

I have now updated the patch to include both changes. I kindly request you to verify the updated patch to ensure that both modifications are properly reflected. Thank you for your attention to detail and your cooperation in resolving this issue.

- *   id = "Image_field_360",
+ *   id = "ImageField360",

It is not necessary to change the plugin ID. It is not required to match the class name; furthermore, plugin IDs use snail case. See AggregatorTitleFormatter.php, for example.

/**
 * Plugin implementation of the 'aggregator_title' formatter.
 *
 * @FieldFormatter(
 *   id = "aggregator_title",
 *   label = @Translation("Aggregator title"),
 *   description = @Translation("Formats an aggregator item or feed title with an optional link."),
 *   field_types = {
 *     "string"
 *   }
 * )
 */
class AggregatorTitleFormatter extends FormatterBase {
  // …
}

   /**
-   * Construct a Image_field_360 object.
+   * Construct a ImageField360 object.

Since that documentation comment is changed, also the description must be changed. The description for a constructor must start with Constructs a new followed by the class name (including its namespace), and end with object.

Reverted plugin ID and added the word "new" in constructor comment.

Please review.

Thanks

The class namespace is still missing, which is what the previous review reported as change too.

The description for a constructor must start with Constructs a new followed by the class name (including its namespace), and end with object.

Please review.

@urvashi, after applying the #patch8, all the phpcs issues seem to be resolved.
As you can see in my attached screenshot.
Please & Thank You.

Automatically closed - issue fixed for 2 weeks with no activity.