The serialization fails if used with Views REST export

Hello, is there some solution to this?

I have the same error here:

The website encountered an unexpected error. Please try again later.
TypeError: array_keys(): Argument #1 ($array) must be of type array, string given in array_keys() (line 313 of modules/xls_serialization/src/Encoder/Xls.php).
array_keys() (Line: 313)
Drupal\xls_serialization\Encoder\Xls->extractHeaders() (Line: 169)
Drupal\xls_serialization\Encoder\Xls->setHeaders() (Line: 75)
Drupal\xls_serialization\Encoder\Xls->encode() (Line: 40)
Symfony\Component\Serializer\Encoder\ChainEncoder->encode() (Line: 306)
Symfony\Component\Serializer\Serializer->encode() (Line: 129)
Symfony\Component\Serializer\Serializer->serialize() (Line: 77)
Drupal\serialization\EventSubscriber\DefaultExceptionSubscriber->on4xx() (Line: 112)
Drupal\Core\EventSubscriber\HttpExceptionSubscriberBase->onException()
call_user_func() (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (Line: 219)
Symfony\Component\HttpKernel\HttpKernel->handleThrowable() (Line: 91)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 57)
Drupal\Core\StackMiddleware\Session->handle() (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 23)
Stack\StackedHttpKernel->handle() (Line: 717)
Drupal\Core\DrupalKernel->handle() (Line: 19)

I am having the same issue here, I'll try to submit a patch today.

This issue is not only applicable to the rest export - it is also applicable to the excel export and views data export modules when authentication is in place.

I have fixed this with 2 changes

I have made changes so the encoder more flexible for the data it is provided with. At the start of encode the encoder is casting everything to an array, but from that point it assumes that it has a nested array. It also makes an assumption that the row keys are numeric - but they do not have to be. So changes have been make to fix the type errors.

Once the issues in encode were fixed the endpoint was still returning errors:

Exception: Deprecated function: stripos(): Passing null to parameter #1 ($haystack) of type string is deprecated
Drupal\Core\EventSubscriber\ActiveLinkResponseFilter->onResponse()() (Line: 85)

This is due to this module using an event subscriber to add the format. This was one common, but now the recommend approach is to use a service provider to register the formats as middleware. CSV serialization implemented the same change 🐛 PHP 8.1 deprecated function warning Fixed which is based on how several other serializers are doing this, e.g:

- https://git.drupalcode.org/project/hal/-/blob/2.x/src/HalServiceProvider...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/jsona...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...
- https://git.drupalcode.org/project/csv_serialization/-/blob/4.x/src/CsvS...

Setting to needs review.

Please note the pipeline is failing as the gitlab ci config is to test the current major - which is Drupal 11 - but this module is not Drupal 11 compatabile.

I run the pipeline with the variable set to test on the previous major (i.e test on Drupal 10) and we can see the test passing here https://git.drupalcode.org/issue/xls_serialization-3362321/-/pipelines/3...

There is one line that has to go, otherwise this is RTBC.

Thank you

Thanks @rosk0 - removed the duplicate comment - thank you for the reviews.

@ericgsmith this also looks like a good candidate for the 2.0.x branch.