- Issue created by @ericgsmith
- Status changed to Needs review
about 1 year ago 8:31pm 24 September 2023 - last update
about 1 year ago 2 pass, 2 fail - last update
about 1 year ago 3 pass The last submitted patch, 3: csv_serialization-php-deprecation-function-3389415-3-test-only.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago 3 pass - π³πΏNew Zealand ericgsmith
Updated approached based on how the following modules add additional formats:
- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago 3 pass - π³πΏNew Zealand ericgsmith
Alright, cleaned up the coding standards and rolled a version against 8.x-1.x for anybody still on Drupal 9.
Updated the issue status. Apologies for the noise / multiple updates on this issue - think this is all ready for review now.
- last update
about 1 year ago Composer require-dev failure Confirming the #8 - 3.0.x patch resolves the deprecated warning during a 403, and on success serves up CSVs with the correct Content-Type header. The new implementation to register the csv format looks odd at first glance but it's how core does this too (see FileServiceProvider and JsonapiServiceProvider).
I didn't review the other patch.
- Status changed to Needs work
about 1 year ago 11:04pm 16 November 2023 - πΊπΈUnited States markdorison
Patch no longer applies cleanly. Please re-roll in a merge request so we can utilize GitLab CI testing.
- Merge request !29Issue #3389415: Replace event subscriber with call to registerFormat via... β (Merged) created by ericgsmith
- Status changed to Needs review
about 1 year ago 5:20am 23 November 2023 - Status changed to RTBC
5 months ago 8:14pm 11 July 2024 Been running the patch on the 4.0 release on my prod site for 5 months without issue. All this in addition to my testing in #9 last year.
I've updated the MR to fix the merge conflicts with 4.x. Test only fails as expected, with the code changes the test passes. Calling this reviewed.
-
markdorison β
committed 5322d4f7 on 4.x authored by
ericgsmith β
Issue #3389415 by ericgsmith: PHP 8.1 deprecated function warning
-
markdorison β
committed 5322d4f7 on 4.x authored by
ericgsmith β
- Status changed to Fixed
5 months ago 9:06pm 17 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.