- Issue created by @Anybody
- π©πͺGermany Anybody Porta Westfalica
**** I just found out that it's already well done in this module, but
font:
is entirely overwritten in CKEditor5 with:
.ck-reset_all :not(.ck-reset_all-excluded *), .ck.ck-reset_all
In this older issue you can see what it looks like without the reset: β¨ Distinguish autocomplete results with "Unpublished" state Fixed
These are related issues on the reset:
π CKEditor 5 readiness Fixed
https://github.com/ckeditor/ckeditor5/issues/11269
β¨ Drastically improve the linking experience in CKEditor 5 Needs workHow should we proceed?
- π©πͺGermany Anybody Porta Westfalica
See https://www.drupal.org/project/drupal/issues/3317769#comment-14995759: β¨ Drastically improve the linking experience in CKEditor 5 Needs work
Just pushed some code to add the .ck-reset_all-excluded CSS class to the entity link container. This class prevents CK5's CSS reset from affecting the styles within the container. Here's what it looks like now (updating IS)
- Status changed to Needs review
over 1 year ago 3:03pm 23 May 2023 - @anybody opened merge request.
- π©πͺGermany Anybody Porta Westfalica
Yay, it works! Test should prove that. I'll ask a teammate to review and test manually.
- π©πͺGermany Anybody Porta Westfalica
@Maintainer: Could you perhaps enable automated tests for issues on 6.1.x? https://www.drupal.org/node/719864/qa β
- Status changed to RTBC
over 1 year ago 7:09am 24 May 2023 Just tried this in an affected project and can confirm this works perfectly fine and fixes the described bug.
- last update
over 1 year ago 83 pass - last update
over 1 year ago 82 pass, 1 fail - πΊπΈUnited States mark_fullmer Tucson
Thanks for reporting and for testing!
I've replicated the contents of the MR as separate patches for 6.0.x and 6.1.x. I've also enabled tested for 6.1.x
The last submitted patch, 14: 3362180.6.1.x.patch, failed testing. View results β
- π©πͺGermany Anybody Porta Westfalica
Thanks @mark_fullmer! The failing test in 6.1.x is unrelated to this change, as the main branch also fails: https://www.drupal.org/pift-ci-job/2674790 β
So settings this back to RTBC for merge. Test should be fixed in a separate issue.
-
mark_fullmer β
committed 24f59f53 on 6.1.x
Issue #3362180 by Anybody, mark_fullmer, thomas.frobieter, Grevil:...
-
mark_fullmer β
committed 24f59f53 on 6.1.x
-
mark_fullmer β
committed 513ab199 on 6.0.x
Issue #3362180 by Anybody, mark_fullmer, thomas.frobieter, Grevil:...
-
mark_fullmer β
committed 513ab199 on 6.0.x
- Status changed to Fixed
over 1 year ago 3:38pm 26 May 2023 - πΊπΈUnited States mark_fullmer Tucson
Thanks everyone! Committed. Thanks, also for creating and referencing π Fix failing 6.1.x test Fixed . We will want to address that sooner rather than later.
Automatically closed - issue fixed for 2 weeks with no activity.