Fix the issues reported by phpcs

Created on 23 May 2023, over 1 year ago

Problem/Motivation

Found this issues reported by phpcs:

FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/gatsby.post_update.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 16 | WARNING | Unused variable $target_settings.
------------------------------------------------------------------------------------------------------------


FILE: ...denttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/tests/src/Kernel/DisabledNodeTypesTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 30 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its
    |       | schema for configurations.
----------------------------------------------------------------------------------------------------------------------


FILE: ...enttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/tests/src/Kernel/GatsbyEntityLoggerTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------
  29 | ERROR   | [ ] Do not disable strict config schema checking in tests. Instead ensure your module properly
     |         |     declares its schema for configurations.
  97 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
     |         |     parentheses
 115 | WARNING | [x] There must be no blank line following an inline comment
 115 | WARNING | [ ] There must be no blank line following an inline comment
 129 | WARNING | [x] There must be no blank line following an inline comment
 129 | WARNING | [ ] There must be no blank line following an inline comment
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/README.md
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 121 | WARNING | Line exceeds 80 characters; contains 81 characters
-----------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/gatsby.install
----------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 21 | ERROR | [ ] Doc comment short description must end with a full stop
 21 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 34 | ERROR | [x] Doc comment short description must end with a full stop
 41 | ERROR | [x] Doc comment short description must end with a full stop
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/src/Form/GatsbyAdminForm.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
 150 | ERROR | [x] Use null coalesce operator instead of ternary operator.
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/src/GatsbyPreview.php
-----------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
-----------------------------------------------------------------------------------------------------------
  80 | ERROR   | Missing parameter comment
  81 | ERROR   | Missing parameter comment
  82 | ERROR   | Missing parameter comment
  98 | ERROR   | Missing parameter comment
  99 | ERROR   | Missing parameter comment
 120 | ERROR   | Missing parameter comment
 121 | ERROR   | Missing parameter comment
 174 | WARNING | Unused variable $endpoint_type.
-----------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/src/Entity/GatsbyLogEntity.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
 202 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------

Time: 1.09 secs; Memory: 12MB

Steps to reproduce

Run this command in the module folder: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml

Proposed resolution

Remaining tasks

FILE: ...denttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/tests/src/Kernel/DisabledNodeTypesTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 30 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its
    |       | schema for configurations.
----------------------------------------------------------------------------------------------------------------------


FILE: ...enttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/gatsby/tests/src/Kernel/GatsbyEntityLoggerTest.php
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
 29 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its
    |       | schema for configurations.
----------------------------------------------------------------------------------------------------------------------

Time: 1.14 secs; Memory: 12MB
📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

🇵🇭Philippines paraderojether

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024