- Issue created by @iyyappan.govind
- 🇮🇳India iyyappan.govind Chennai, India
If handlers satifies all the conditions then status should be enabled. If we show status disabled then it is confusing. So if all conditions are met then I set status true in the patch.
- Status changed to Needs review
almost 2 years ago 4:13am 23 May 2023 - last update
almost 2 years ago 537 pass - Status changed to Closed: won't fix
almost 2 years ago 6:59pm 25 May 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
I think it is fine to allow site builders to resend any email. For example disabled email handlers are displayed.
- 🇮🇳India iyyappan.govind Chennai, India
Hi jrockowitz,
I understand your point and I agree with you. But think about the case like, content editor or content manager are using resend page effectively and frequently to send an email to webform submition user. Content edtior would like to send an proper email based on the State field (custom field) which has nearly 20 state and 20 individual email handlers. In this case if we list 20 email handlers then the editor or site builder will get confusion and there is possibility to choose wrong email handler which is not relevant to current state (hence we are allowing any field in conditions to add it). Looking forward your response.
- Status changed to Needs review
almost 2 years ago 6:25am 1 June 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
Your point is very reasonable but we should only address this via webform 6.2.x.
A compromise might be to group/hide disabled messages to improve the UX while still allowing all messages to be resent.
- last update
almost 2 years ago 534 pass - 🇺🇸United States jrockowitz Brooklyn, NY
Please review the attached patch, which still needs test coverage.
- last update
over 1 year ago 536 pass - last update
over 1 year ago 536 pass - last update
over 1 year ago 536 pass - Status changed to Fixed
over 1 year ago 11:46am 7 October 2023 - 🇺🇸United States jrockowitz Brooklyn, NY
I did another manual review, and I am going to commit this because it is a helpful feature.
-
jrockowitz →
authored dd66fd5d on 6.2.x
Issue #3362015 by jrockowitz, iyyappan.govind: Email Handler is not...
-
jrockowitz →
authored dd66fd5d on 6.2.x
- 🇺🇸United States jrockowitz Brooklyn, NY
My patch caused a major regression. At this point, I think this feature request/issue is not worth addressing.
If someone wants to take over this task and collaborate with other people to provide a tested and stable solution, please reopen this ticket.
Otherwise, people can use the initial patch → AS-IS.
@see 🐛 Unable to resend email handlers when one or more handler is disabled Needs review
- 93726146 committed on 6.2.x
Revert "Issue #3362015 by jrockowitz, iyyappan.govind: Email Handler is...
- 93726146 committed on 6.2.x
Automatically closed - issue fixed for 2 weeks with no activity.