Fix the issues reported by phpcs

FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/ad_entity/ad_entity.install ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 116 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up | | over multiple lines ---------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/ad_entity/ad_entity.services.yml ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 21 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/ad_entity/RELEASE_NOTES.md ------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------- 8 | WARNING | Line exceeds 80 characters; contains 94 characters ------------------------------------------------------------------------------------------------- FILE: ...inees/New/drupalorgsite/docroot/modules/contrib/ad_entity/modules/ad_entity_adtech_v2/ad_entity_adtech_v2.module ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 72 | ERROR | Unnecessarily gendered language in a comment ---------------------------------------------------------------------------------------------------------------------- FILE: ...es/New/drupalorgsite/docroot/modules/contrib/ad_entity/modules/ad_entity_adtech_v2/ad_entity_adtech_v2.theme.inc ---------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------- 19 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 26 spaces but found 7 spaces 20 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 27 spaces but found 8 spaces 21 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 29 spaces but found 10 spaces 22 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 20 spaces but found 1 space ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- FILE: ...orgsite/docroot/modules/contrib/ad_entity/modules/ad_entity_adtech_v2/src/Plugin/ad_entity/AdType/AdtechType.php ---------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------- 479 | ERROR | Description for the @return value is missing 493 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/New/drupalorgsite/docroot/modules/contrib/ad_entity/ad_entity.module ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 109 | ERROR | The array declaration extends to column 188 (the limit is 80). The array content should be split up | | over multiple lines ---------------------------------------------------------------------------------------------------------------------- FILE: ...s/studenttrainees/New/drupalorgsite/docroot/modules/contrib/ad_entity/src/Plugin/Field/FieldType/ContextItem.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 91 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the | | allowed_classes option. ---------------------------------------------------------------------------------------------------------------------- FILE: ...rs/studenttrainees/New/drupalorgsite/docroot/modules/contrib/ad_entity/src/Plugin/Block/AdDisplayIframeBlock.php ---------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ---------------------------------------------------------------------------------------------------------------------- 34 | ERROR | [x] Use null coalesce operator instead of ternary operator. 44 | ERROR | [x] Use null coalesce operator instead of ternary operator. ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- Time: 3.32 secs; Memory: 16MB

Comments & Activities

Issue created by @paraderojether
Issue was unassigned.
Status changed to Needs review over 2 years ago4:08am 18 May 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & sqlite-3.27
last update over 2 years ago
Checkout Error
Comment over 2 years ago →
🇵🇭Philippines paraderojether
Created a patch to fix the issue reported by phpcs.

Please review.
Thank You.
First commit to issue fork.
Comment over 2 years ago →
🇮🇳India dineshkumarbollu
Hi

After applying patch 2 phpcbf issues are present
Comment over 2 years ago →
🇵🇭Philippines paraderojether
Hi dineshkumarbollu,

I found in your commit that you made a changes in this files; ad-display.html.twig, and ad-display-iframe.html.twig, You also have total of 11 changed files, while patch #2 only has 9 changed files.

Look at the screenshot attached.
Please check. Thank You.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Comments & Activities