Convert config schema to label for views use_more_text

Created on 17 May 2023, about 1 year ago
Updated 19 May 2023, about 1 year ago

Problem/Motivation

The use_more_text defined as boolean in core/modules/views/config/schema/views.data_types.schema.yml but stores translatable text

Steps to reproduce

core/modules/comment/config/optional/views.view.comment.yml:859:      use_more_text: more
core/modules/comment/tests/modules/comment_test_views/test_views/views.view.test_comment_schema.yml:274:      use_more_text: more
core/modules/contextual/tests/modules/contextual_test/config/optional/views.view.contextual_recent.yml:289:      use_more_text: More
core/modules/node/config/optional/views.view.content_recent.yml:290:      use_more_text: More
core/modules/user/config/optional/views.view.user_admin_people.yml:877:      use_more_text: more
core/modules/views/config/schema/views.data_types.schema.yml:154:        use_more_text:
core/modules/views/config/schema/views.data_types.schema.yml:225:    use_more_text:

core/modules/views/src/Plugin/views/display/DisplayPluginBase.php:487:          'use_more_text' => TRUE,

core/modules/views/tests/modules/views_test_config/test_views/views.view.test_display_more.yml:39:      use_more_text: 'custom more text'
core/modules/views/tests/modules/views_test_config/test_views/views.view.test_page_display.yml:28:      use_more_text: more
core/modules/views/tests/modules/views_test_config/test_views/views.view.test_token_view.yml:280:      use_more_text: '%1-more-text-!1'

sync/views.view.tmgmt_job_overview.yml:        use_more_text: false
sync/views.view.tmgmt_job_overview.yml:      use_more_text: 'See all jobs Β»'
sync/views.view.tmgmt_job_overview.yml:        use_more_text: false
sync/views.view.tmgmt_job_overview.yml:      use_more_text: 'See all jobs Β»'

Proposed resolution

1 replace type with label
2 add post update hook to re-save affected views
3 add test to make sure view is resaved

Remaining tasks

- patch
- review
- commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

πŸ› Bug report
Status

Closed: works as designed

Version

10.1 ✨

Component
ViewsΒ  β†’

Last updated 32 minutes ago

Created by

πŸ‡«πŸ‡·France andypost

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024