- Issue created by @alok_singh
- @alok_singh opened merge request.
- Status changed to Needs review
over 1 year ago 10:51am 16 May 2023 - Status changed to RTBC
over 1 year ago 5:37am 17 May 2023 - Assigned to arti_parmar
- Status changed to Needs work
over 1 year ago 12:37pm 16 June 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:40pm 16 June 2023 - 🇮🇳India Raveen Kumar
Hello Guys. Hope all are doing well.
I have reviewed and implemented the #patch 7 and it looks resolving the issue.
Can be moved to RTBC! And Thank you. - Status changed to RTBC
over 1 year ago 7:50am 21 June 2023 - Status changed to Needs work
over 1 year ago 11:23am 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what should be fixed/changed. Neither the title nor screenshots are sufficient to describe what the issue is, even in the case a patch is provided.
- Status changed to Needs review
over 1 year ago 12:26pm 23 June 2023 - Status changed to Needs work
over 1 year ago 2:34pm 23 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
package: Custom version: VERSION -core: 8.x +core_version_requirement: '^8 || ^9 || ^10' +base theme: false
This issue is not about fixing the core requirements or the absence of the
base theme
key, but the presence of a duplicateversion
key.Truly, version: VERSION should be removed, because that is only used by Drupal core modules and themes.
Then, the following lines (and the comment before them) should be removed too, since they are added from the drupal.org packaging script.
version: '8.x-5.x-dev' project: 'himalaya' datestamp: 1447044549
The patch correctly removes them, but it touches the core requirements too, which should not be touched by this issue.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
As for the
base theme
key, that is required in Drupal 9 and optional in Drupal 8. Since this issue is about theversion
key, that change is off-topic, though. - Status changed to Needs review
over 1 year ago 6:25pm 26 June 2023 - Status changed to Needs work
over 1 year ago 7:04pm 26 June 2023 - Status changed to Needs review
over 1 year ago 7:33am 27 June 2023 - Status changed to RTBC
over 1 year ago 7:36am 27 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The MR correctly changes the theme files as per issue topic.