- Issue created by @mherchel
- 🇺🇸United States mherchel Gainesville, FL, US
I tracked it down to the toolbar. As of now I'm guessing that this may be a regression from 🐛 Toolbar tray rendering can result "flickering" resizing of content area to accommodate open trays Fixed
- 🇺🇸United States mherchel Gainesville, FL, US
So the black bar appears when both the
toolbar-horizontalandtoolbar-loadingCSS classes are present on the<html>element. When JS removes these, the toolbar goes away. - 🇺🇸United States mherchel Gainesville, FL, US
I believe I figured it out. The problem (I believe) is that Claro uses
visibility: hiddento hide the.toolbar-loading.toolbar-horizontal .toolbar .toolbar-bar .toolbar-tab:last-child .toolbar-trayelement.Visibility hidden maintains the "space" of an element, but prevents it from "painting" on the screen. This is what's creating the space.
In the screenshot below, I have JavaScript paused in the debugger so I can investigate this issue. I then toggle off/on the
visibility: hiddenrule, so the element that is creating the space becomes apparent. - Status changed to Needs review
over 1 year ago 3:29pm 14 May 2023 - last update
over 1 year ago Custom Commands Failed - 🇺🇸United States mherchel Gainesville, FL, US
Patch attached. Instead of
visibility: hidden(which maintains space), we should be usingdisplay: none(which does not maintain space). And because we're usingdisplay: none, all of the other rules in the ruleset are irrelevant, so they can be removed. - last update
over 1 year ago CI aborted - last update
over 1 year ago 29,388 pass - Status changed to RTBC
over 1 year ago 2:16pm 15 May 2023 - 🇺🇸United States smustgrave
Thought my container was just being slow but I've noticed as well.
- last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,387 pass, 2 fail - 🇫🇮Finland lauriii Finland
Let's make the same change in Stable for consistency. I didn't research the root cause to this problem but was able to reproduce the problem consistently by triggering a pause and refreshing the page. I had to do this using the guest profile of Chrome to disable all browser plugins.
The last submitted patch, 10: 3360245-10.patch, failed testing. View results →
- 🇬🇧United Kingdom longwave UK
Not sure what purpose the immediate following rule serves if the parent of this is now
display:none?.toolbar-loading.toolbar-horizontal .toolbar .toolbar-bar .toolbar-tab:last-child .toolbar-tray .toolbar-lining { width: 999em; }This shouldn't derail this issue, but worth exploring in a followup?
- 🇬🇧United Kingdom longwave UK
The fail is 🐛 [random test failure] InstallerExistingConfig[SyncDirectory]MultilingualTest::testConfigSync Fixed , shouldn't block commit.
- last update
over 1 year ago 29,388 pass - 🇺🇸United States mherchel Gainesville, FL, US
Tests are passing now.
+1 to the changes from @lauriii in #10.
- Status changed to Needs work
over 1 year ago 5:23pm 18 May 2023 - 🇺🇸United States mherchel Gainesville, FL, US
This actually needs to be fixed in the toolbar module too. Just saw that it can happen in Olivero.
Patch incoming.
- Status changed to RTBC
over 1 year ago 5:26pm 18 May 2023 - 🇺🇸United States mherchel Gainesville, FL, US
Scratch that. I saw the problem in Olivero, however the Toolbar is still loading the Claro stylesheet. The problem doesn't seem to exist within the Toolbar module CSS.
Setting back to RTBC.
- Status changed to Fixed
over 1 year ago 6:00pm 18 May 2023 - 🇫🇮Finland lauriii Finland
Automatically closed - issue fixed for 2 weeks with no activity.