- Issue created by @Shanu Chouhan
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:11am 13 May 2023 - Status changed to Needs work
over 1 year ago 2:10pm 14 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what should be fixed/changed. The title is not sufficient to describe what the issue is, even in the case a patch is provided.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
(Also, that alone is not a change required by the Drupal coding standards.)
- 🇮🇳India Raveen Kumar
@apaderno,
I believe @Shanu is saying for file - src/controller/EntityUpdateDiffJsonController.php. The foreach loop is having $key variable in its syntax - To which she thinks is unused. Because we are iterating the array values through the $value variable. Basically, we use the $key if we are having data in associative arrays[0],[1],[2].say- for indexing. Thank You. - 🇮🇹Italy apaderno Brescia, 🇮🇹
@Raveen Thakur Still, the issue summary should report what the issue is. That is necessary to understand if the patch/MR is correct and whether the change is proposed for the correct reason.
- First commit to issue fork.
- @rsalvado opened merge request.
- Status changed to Fixed
over 1 year ago 10:50am 22 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.