Rename "Attributes" to "Link attributes" to distinguish them from other (item) attributes

Simple but helpful. And needed to better work with other attributes modules. Please review.

I think I would prefer to make this a configuration option in the edit: widget settings, defaulting to 'Attributes'

But +1 for the concept

Thanks!

@larowlan: Thanks, well isn't that a bit too much and might lead to inconsistencies across forms? For example with ✨ Add Default menu_link_content attributes UI Needs review it would mean, you'd have to change it for each menu.

You're the maintainer and you decide of course :) but I'd really tend to say "Link attributes" is short and clear and removes the risk of misunderstandings or mixing up attribute forms without needing the user to site builder to make changes.

So from my perspective the simple solution is the better one here for SBX. Would you mind to discuss that again?

I would want people to be able to configure it for each widget, just like they can for what is/isn't enabled

Changing the name for everyone could cause translation issues for those who've not yet translated it as well as confuse people who've been using this module for 5 years plus.

That's my thinking.

I don't think it will have an impact on the UI issue.

Thanks @larowlan :) Then let's do it that way!
I'll prepare the MR asap or ask a teammate.

The label naming conflicts will be mitigaged by 📌 Move the 'menu_link_content' 'link' base field widget overwrite into its own submodule Fixed which totally makes sense here in combination with other modules to set attributes on menu items (li) or menus (ul).

Link fields typically don't have other attribute fieldsets or use modules like fences, which don't conflict in the UI.

After thinking about this for a while, I think with 📌 Move the 'menu_link_content' 'link' base field widget overwrite into its own submodule Fixed we could even discuss to close this won't fix. Who needs this, could use the patch. But due to the incompatibilities mentioned in 🐛 Duplicate menu item settings with menu_link_attributes Fixed with multiple modules for menu_link_content attributes, I think this combination won't be useful.

And in other cases the label can be kept as "Attributes". So let's postpone this for @larowlan to decide. Sorry for the back and forth ... -.-

📌 Move the 'menu_link_content' 'link' base field widget overwrite into its own submodule Fixed is now fixed! So setting this back to NW.

@larowlan what do you think about #10?

@Anybody given you opened this to address a pain point, if the other issue has resolved it, happy to close it and avoid extra complexity in the code

I finally think it's okay to close it now, based on #10. If anyone disagrees, feel free to reopen. Thanks @larowlan :)