- π©πͺGermany Anybody Porta Westfalica
@larowlan any maintainer feedback what should be done? This issue is existing since the Drupal 8 early days and it's really uncool. :(
We'd like to help fixing this, but first need a decision, please.
I'd vote for one feature-complete solution (module merge), but anything is fine which solves the conflict. - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Don't use both modules would be my suggestion
Or if you want to use this module for other fields and menu link attributes for only menu, you can use https://www.previousnext.com.au/blog/overriding-base-field-labels-and-de... to switch the widget for menu links to _not_ use link_attributes
- π©πͺGermany Anybody Porta Westfalica
@larowlan thanks! Would it also be fine for you, if we added a submodule for menu items (
<li>
) attributes so the menu_links_attributes (which does both<li>
's and<a href>
's) isn't needed anymore when using link_attributes?I updated the issue summary to make the situation clearer.
But writing this, I think perhaps a separate module "menu_item_attributes" with a clear focus would be better.
I just found https://www.drupal.org/project/menus_attribute β which we could try in combination with link_attributes. (Still it doesn't seem to be well maintained) - π©πͺGermany Anybody Porta Westfalica
We discussed this in our team this morning and had a look at the different alternatives.
Our final result is, that the best solution will be to move the menu_link_content functionality from link_attributes into a submodule so it can be explicitly disabled / enabled. This allows to use link_attribute for link fields without conflicting with other modules for the menu link attributes! :)
See π Move the 'menu_link_content' 'link' base field widget overwrite into its own submodule Fixed
- Status changed to Postponed
over 1 year ago 10:55am 15 May 2023 - π©πͺGermany Anybody Porta Westfalica
on π Move the 'menu_link_content' 'link' base field widget overwrite into its own submodule Fixed which will allow to disable this functionality. Once that is fixed, we should document, which combinations are working / suggested here.
- Status changed to Active
over 1 year ago 9:57am 21 June 2023 - π©πͺGermany Anybody Porta Westfalica
π Move the 'menu_link_content' 'link' base field widget overwrite into its own submodule Fixed is resolved. @Grevil would you be so kind to test the combinations? If you have any questions, feel free to ask. Might be easier to get started after an explanation, if you don't remember the situation here anymore.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I think this can be closed now given π Move the 'menu_link_content' 'link' base field widget overwrite into its own submodule Fixed - can folks try the 2.x branch without the sub-module and report back?
Thanks!
- Status changed to Fixed
over 1 year ago 11:37am 22 June 2023 - π©πͺGermany Anybody Porta Westfalica
Great news! This is now fixed with the 2.0.0 release.
Now that you can disable the menu link content integration, the module doesn't conflict with dedicated modules like menu_link_attributes anymore and both modules can be used without any issues.menu_link_attributes for menu items and link_attributes for link fields.
You should even be able to use https://www.drupal.org/project/menus_attribute β without issues.Thanks a lot @larowlan for the separation!
Automatically closed - issue fixed for 2 weeks with no activity.