Fix failing test since Drupal 10.1.x

Queueing a test to show the issue without changing anything!

Okay let's hope linebreaks or hidden characters are the reason... the last tests at least shows some differences to start with:

--- Expected
+++ Actual
@@ @@
-'  
-    Public node
-    
-  '
+'
+
+
+      
+      
+Public node
+
+    
+
+
+
+
+  
+
+  
+
+
+'

Interesting, looks like this test fails since 10.1.x
Might this be related to 📌 Strip HTML tags when using assertEquals() to compare markup Fixed perhaps?

Still couldn't find a difference between:

-'Public node'
+'Public node'

and guess it must be something like a hidden character, escaping or something like that... -.-

Okay I was now able to reproduce this locally, after upgrading to 10.1.x-dev!

Here are the correct details, invisible online:

1) Drupal\Tests\twig_tweak\Kernel\EntityViewBuilderTest::testEntityViewBuilder
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'<article role="article"><h2><a href="/node/1" rel="bookmark"><span>Public node</span></a></h2><div></div></article>'
+'<article><h2><a href="/node/1" rel="bookmark"><span>Public node</span></a></h2><div></div></article>'

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79
/var/www/html/web/modules/contrib/twig_tweak/tests/src/Kernel/EntityViewBuilderTest.php:95
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

I tried switching to self::assertXmlStringEqualsXmlString() so it doesn't need all the ugly markup cleanups anymore, but sadly there seems to be a bug in PHPUnit 9,x (9.5 required by Drupal 10.1.x) so it's not usable (yet):

Fatal error: Uncaught Exception: Serialization of 'DOMDocument' is not allowed in Standard input code:84

Similar here:
https://github.com/RSS-Bridge/rss-bridge/issues/2704

I couldn't find a way around it, so I'll proceed with the (ugly) cleanups for now. But as soon as possible, that should better be switched, I guess.

This was the simple reason: 📌 Remove redundant role="article" from html tags Fixed

@Chi: Would be super cool if you could merge this, as the failing tests currently polute the other issues test results.
See #10 for the root cause (core template change).

Only for that reason I'm setting the priority to major.

Sorry totally missed this issue.
Moving credits to 💬 Cheat sheet: format_size fliter needs explanation Fixed .