- Issue created by @alison
- π·πΊRussia Chi
It's correct.
format_size
is just a thin wrapper around Drupal format_size() function. Same applies to many other functions and filters. They just integrate Drupal functions and services into Twig.I wonder if we put more details into the documentation would it be still correct to call it cheat sheet? AFK cheat sheet is a document for those who don't want to spend time on reading detailed documentation.
- πΊπΈUnited States alison
1. Thanks for confirming + clarifying!
2. Mmmmm good point.......................... hmmm..............
I posted a related comment on π Update 3.x cheat sheet with details from 2.x cheat sheet Needs work , so, my input here (3363045) may change depending on your thoughts over there, BUT, an idea based on your feedback on this issue here (3363045):
We could add a general note to the module README, like, "some functions and filters are simply wrappers for Drupal functions and services; for example: _____" - π·πΊRussia Chi
Generally users don't need to know what's inside Twig Tweak filters and functions. Because it is implementation details. What they need to know is how to use those functions and filters.
- πΊπΈUnited States alison
Cool! I'd add "what they do" to what I would want a cheat sheet to have (I really had no idea what "format_size" does). So I think that could easily get a short-sentence explanation in the cheat sheet, and then maybe a sentence in the main README with a "some are simply wrappers etc etc" type of explanation, like what I suggested.
Anyway, I'll give it a try and we can go from there.
Thanks for the guidance!
- Assigned to alison
- last update
over 1 year ago 10 pass, 1 fail - @alison opened merge request.
- Status changed to Needs review
over 1 year ago 12:42am 27 May 2023 - πΊπΈUnited States alison
Mmkay, first draft is in a merge request, ready for review.
(One test failed, I'm re-running it.)
- last update
over 1 year ago 10 pass, 1 fail - πΊπΈUnited States alison
Dang. I'm afraid I don't understand testing well enough to know why that one test is failing. I don't see how the changes I made could have anything to do with
EntityViewBuilderTest
π - last update
over 1 year ago 11 pass - π·πΊRussia Chi
The failure is irrelevant to this issue. It was caused by some recent changes in Drupal core. I just updated the tests.
- last update
over 1 year ago 11 pass -
Chi β
committed 832a021c on 3.x authored by
alison β
Issue #3363045: Feature(s) missing documentation
-
Chi β
committed 832a021c on 3.x authored by
alison β
- Status changed to Fixed
over 1 year ago 5:30am 27 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.