Do not use persist tag for keyvalue.memory in KernelTestBase

The KernelTestBase fix was first introduced in #2368263-35: Remove the persist service tag → by amateescu

dww → credited amateescu → .

Nice, thanks! Per #3 crediting @amateescu.

The MR is small, simple, and well-documented. Curious to see if the bot has any problems with this. So far, looks RTBC to me.

Thanks again,
-Derek

Nothing to object to in the code. The issue title and summary are clear. This doesn't need a change record, since no one needs to know or care that this implementation detail is different. Ditto a release note. Bot is happy, so am I. 😉 Ship it!

Thanks!
-Derek

I don't think we need explicit test coverage of this change. I asked about it in #bugsmash and @catch replied:

If the patch from the other issue fails without it that can count as test coverage, I didn't check if that's the case.

So I tried a combined patch over there. We went from 27 fails → with the patch at comment #3278493-95: Make it easier for theme builders to enable Twig debugging and disable render cache → to only 1 fail by also applying this patch → at comment #98 ✨ Make it easier for theme builders to enable Twig debugging and disable render cache Fixed . That seems like sufficient improvement to know this is what we need. 😅🙏

Cheers,
-Derek

Committed e129b1e and pushed to 10.1.x. Thanks!

Thanks!

Is this back-port-able?

I’m having trouble imagining how the new approach could cause any disruption. It seems obviously more reliable and better for making sure the key value survives. Anyone relying on key value getting clobbered on a container build seems like they have buggy tests and should fix them. 😉

If we get a green test run on 10.0.x/9.5.x I don't see an issue with backporting it.

Here's exactly the MR diff in patch form, which I just checked applies cleanly to both 9.5.x and 10.0.x branches.

Bot is green on both branches. Cherry-pick away. 😅

Cherry-picked and pushed to 10.0.x and 9.5.x, thanks!

backport to 9.5 needs revert and new patch without type for property https://www.drupal.org/pift-ci-job/2663367 →

Sorry for noise, valid issue is 📌 Improve how KernelTestBase manages its persistent key value storage Fixed

Automatically closed - issue fixed for 2 weeks with no activity.